Fixed slashes in ////zeta in BOPE tutorial #1777
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Balandat
approved these changes
Apr 4, 2023
|
@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Codecov Report
@@ Coverage Diff @@
## main #1777 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 170 170
Lines 14760 14760
=========================================
Hits 14760 14760 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@esantorella merged this pull request in 7b48c18. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 28, 2023
…1907) Summary: ## Motivation * A Pandas upgrade changed the way that Greek letters needed to be escaped for plotting, so in #1777 we changed "\\\\zeta" to "\\zeta". However, this caused failures for those using an older version of Pandas. Therefore, we will simply represent it as "zeta" for plotting. * Since only one replication is run, there is no need to compute an "sem", since it is always NaN over one data point. So I removed that part of the analysis and plotting logic. ### Have you read the [Contributing Guidelines on pull requests](https://github.com/pytorch/botorch/blob/main/CONTRIBUTING.md#pull-requests)? Yes Pull Request resolved: #1907 Test Plan: I ran the notebook. ## Related PRs #1777 Reviewed By: Balandat Differential Revision: D47096998 Pulled By: esantorella fbshipit-source-id: 8739c2c5685ed76e41258e46316a69dcc5527bc9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A pandas update broke the CI. This fixes it.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Repro'd the error locally and confirmed that this fixes it. The CI should pass now.