Refactor test function test utils #1839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D45969036 |
Balandat
added a commit
to Balandat/botorch
that referenced
this pull request
May 18, 2023
Summary: Pull Request resolved: pytorch#1839 Refactors the test utils for botorch test functions to make things more modular. Instead of subclassing the base test cases, we now have class Mixins for synthetic, constrained, and multi-objective problems. This means we can mix-and-match the test case as needed. This also flattens the `TestMultiObjectiveProblems` and `TestConstrainedMultiObjectiveProblems` test collections (the idea behind the test design is that we have separate test cases for each problem (potentially with different arguments) to better identify and group the tests, so this reestablishes that. Differential Revision: D45969036 fbshipit-source-id: 227662f7914eba3e461a604b6ace592cc9fca227
Balandat
force-pushed
the
export-D45969036
branch
from
1d5afd0
to
006c400
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45969036 |
Balandat
added a commit
to Balandat/botorch
that referenced
this pull request
May 18, 2023
Summary: Pull Request resolved: pytorch#1839 Refactors the test utils for botorch test functions to make things more modular. Instead of subclassing the base test cases, we now have class Mixins for synthetic, constrained, and multi-objective problems. This means we can mix-and-match the test case as needed. This also flattens the `TestMultiObjectiveProblems` and `TestConstrainedMultiObjectiveProblems` test collections (the idea behind the test design is that we have separate test cases for each problem (potentially with different arguments) to better identify and group the tests, so this reestablishes that. Differential Revision: D45969036 fbshipit-source-id: 2b3c00813185b93bfd55874f34b330ed7280d52b
Balandat
force-pushed
the
export-D45969036
branch
from
006c400
to
5f7a444
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45969036 |
Codecov Report
@@ Coverage Diff @@
## main #1839 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 170 170
Lines 14937 14939 +2
=========================================
+ Hits 14937 14939 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
esantorella
reviewed
May 18, 2023
esantorella
reviewed
May 18, 2023
esantorella
reviewed
May 18, 2023
esantorella
reviewed
May 18, 2023
botorch/utils/testing.py
Outdated
| @@ -93,7 +93,7 @@ def assertAllClose( | |||
| ) | |||
|
|
|||
|
|
|||
| class BaseTestProblemBaseTestCase: | |||
| class BaseTestProblemTestCaseMixIn: | |||
|
|
|||
| functions: List[BaseTestProblem] | |||
There was a problem hiding this comment.
Suggested change
| functions: List[BaseTestProblem] | |
| functions: Sequence[BaseTestProblem] = [] |
esantorella
approved these changes
May 18, 2023
Balandat
added a commit
to Balandat/botorch
that referenced
this pull request
May 19, 2023
Summary: Pull Request resolved: pytorch#1839 Refactors the test utils for botorch test functions to make things more modular. Instead of subclassing the base test cases, we now have class Mixins for synthetic, constrained, and multi-objective problems. This means we can mix-and-match the test case as needed. This also flattens the `TestMultiObjectiveProblems` and `TestConstrainedMultiObjectiveProblems` test collections (the idea behind the test design is that we have separate test cases for each problem (potentially with different arguments) to better identify and group the tests, so this reestablishes that. Reviewed By: esantorella Differential Revision: D45969036 fbshipit-source-id: 7e9ec80ed93bab55e857761dd462545de44ceca9
Balandat
force-pushed
the
export-D45969036
branch
from
5f7a444
to
7d79d52
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45969036 |
Summary: Pull Request resolved: pytorch#1839 Refactors the test utils for botorch test functions to make things more modular. Instead of subclassing the base test cases, we now have class Mixins for synthetic, constrained, and multi-objective problems. This means we can mix-and-match the test case as needed. This also flattens the `TestMultiObjectiveProblems` and `TestConstrainedMultiObjectiveProblems` test collections (the idea behind the test design is that we have separate test cases for each problem (potentially with different arguments) to better identify and group the tests, so this reestablishes that. Reviewed By: esantorella Differential Revision: D45969036 fbshipit-source-id: dbb694536aff9c844fc7060f115aedfbb16a2575
Balandat
force-pushed
the
export-D45969036
branch
from
7d79d52
to
e20b24c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45969036 |
|
This pull request has been merged in 98b4194. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Refactors the test utils for botorch test functions to make things more modular.
Instead of subclassing the base test cases, we now have class Mixins for synthetic, constrained, and multi-objective problems. This means we can mix-and-match the test case as needed.
Further,
BaseTestProblemTestCasenow subclassesBotorchTestCaseso that we don't need to subclass fromBotorchTestCaseseparately for every test.Finally, this flattens the
TestMultiObjectiveProblemsandTestConstrainedMultiObjectiveProblemstest collections (the idea behind the test design is that we have separate test cases for each problem (potentially with different arguments) to better identify and group the tests, so this reestablishes that.Differential Revision: D45969036