Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix escaped character error in BOPE tutorial and simplify plotting #1907

Closed
wants to merge 1 commit into from
Closed

Fix escaped character error in BOPE tutorial and simplify plotting #1907

wants to merge 1 commit into from

Conversation

esantorella
Copy link
Member

Motivation

  • A Pandas upgrade changed the way that Greek letters needed to be escaped for plotting, so in Fixed slashes in ////zeta in BOPE tutorial #1777 we changed "\\zeta" to "\zeta". However, this caused failures for those using an older version of Pandas. Therefore, we will simply represent it as "zeta" for plotting.
  • Since only one replication is run, there is no need to compute an "sem", since it is always NaN over one data point. So I removed that part of the analysis and plotting logic.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

I ran the notebook.

Related PRs

#1777

@esantorella esantorella added the bug Something isn't working label Jun 28, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 28, 2023
@facebook-github-bot
Copy link
Contributor

@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Balandat
Balandat approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@Balandat Balandat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@facebook-github-bot
Copy link
Contributor

@esantorella merged this pull request in e1464f6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Balandat Balandat Balandat approved these changes

@ItsMrLin ItsMrLin Awaiting requested review from ItsMrLin

Assignees
No one assigned
Labels
bug Something isn't working CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@esantorella @facebook-github-bot @Balandat @ItsMrLin