Require Python 3.9+, test for 3.9 and 3.11 #1924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## main #1924 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 177 177
Lines 15683 15683
=======================================
Hits 15675 15675
Misses 8 8 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Interesting, looks like py 3.11 is stricter on the dataclasses, I guess this will require a small patch. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 10, 2023
…1927) Summary: ## Motivation See error here: https://github.com/pytorch/botorch/actions/runs/5508336054/jobs/10039481686?pr=1924 * Tested with a tensor instead of a `DenseContainer` since we needed something non-mutable * Added a test that the tensor is properly cast to a `DenseContainer` * made code more readable (for me anyway) ### Have you read the [Contributing Guidelines on pull requests](https://github.com/pytorch/botorch/blob/main/CONTRIBUTING.md#pull-requests)? Yes Pull Request resolved: #1927 Test Plan: Units ## Related PRs Unblocks #1924 Reviewed By: saitcakmak Differential Revision: D47341881 Pulled By: esantorella fbshipit-source-id: 64c497504bffde8cc227dff8eaaa85e17aa36b95
|
@esantorella has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
saitcakmak
approved these changes
Jul 25, 2023
|
@esantorella merged this pull request in 8c763b3. |
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Jul 26, 2023
Summary: Follow up to pytorch/botorch#1924 to avoid CI failures. NOTE: We cannot support 3.11 currently due to a failure in torchx tests. See pytorch/torchx#744 Pull Request resolved: #1744 Reviewed By: esantorella Differential Revision: D47780385 Pulled By: saitcakmak fbshipit-source-id: af69631befbdb3035f1a969c03d73defb070e19e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Python 3.11 was released over 8 months ago, so we should be testing for it. We can also drop support for Python 3.8, which was supplanted by 3.9 nearly 3 years ago.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Manually running nightly cron: https://github.com/pytorch/botorch/actions/runs/5508340274