Added posterior_transform to posterior method in ApproximateGPyTorchModel #2531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Balandat
reviewed
Sep 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2531 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 193 193
Lines 17006 17010 +4
=======================================
+ Hits 17003 17007 +4
Misses 3 3 ☔ View full report in Codecov by Sentry. |
Balandat
reviewed
Sep 12, 2024
|
@Balandat I have addressed the requested changes. |
|
@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Balandat
reviewed
Sep 16, 2024
|
@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Balandat
reviewed
Sep 16, 2024
|
@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes #2530. Adds a new posterior_transform parameter to the posterior method of ApproximateGPyTorchModel.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
I was able to generate candidate points with ExpectedImprovement acquisition function with a SingleTaskVariationalGP that was trained on 2 output columns.
Related PRs
NA