From 7ca0c3ae435adb3615df10e1ebcdcdfaf9650001 Mon Sep 17 00:00:00 2001 From: Huy Do Date: Mon, 6 Mar 2023 14:23:42 -0800 Subject: [PATCH 1/7] Switch deprecated ubuntu-18.04 runner to self-hosted 2xlarge --- .github/workflows/build-libtorch-images.yml | 6 +++--- .github/workflows/build-magma-windows.yml | 2 +- .github/workflows/build-manywheel-images.yml | 8 ++++---- .github/workflows/build-nvidia-images.yml | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/build-libtorch-images.yml b/.github/workflows/build-libtorch-images.yml index d32b6e4b0..5d5e34bff 100644 --- a/.github/workflows/build-libtorch-images.yml +++ b/.github/workflows/build-libtorch-images.yml @@ -25,7 +25,7 @@ env: jobs: build-docker-cuda: - runs-on: ubuntu-18.04 + runs-on: linux.2xlarge strategy: matrix: cuda_version: ["11.8", "11.7", "11.6"] @@ -44,7 +44,7 @@ jobs: run: | libtorch/build_docker.sh build-docker-rocm: - runs-on: ubuntu-18.04 + runs-on: linux.2xlarge strategy: matrix: rocm_version: ["5.3", "5.4.2"] @@ -63,7 +63,7 @@ jobs: run: | libtorch/build_docker.sh build-docker-cpu: - runs-on: ubuntu-18.04 + runs-on: linux.2xlarge steps: - name: Checkout PyTorch uses: actions/checkout@v3 diff --git a/.github/workflows/build-magma-windows.yml b/.github/workflows/build-magma-windows.yml index 7a312febc..56d4cd3a6 100644 --- a/.github/workflows/build-magma-windows.yml +++ b/.github/workflows/build-magma-windows.yml @@ -38,7 +38,7 @@ jobs: push-windows-magma: if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }} environment: magma - runs-on: ubuntu-18.04 + runs-on: linux.2xlarge needs: build-windows-magma steps: - name: Download all artifacts diff --git a/.github/workflows/build-manywheel-images.yml b/.github/workflows/build-manywheel-images.yml index bbd221989..2ae360a85 100644 --- a/.github/workflows/build-manywheel-images.yml +++ b/.github/workflows/build-manywheel-images.yml @@ -27,7 +27,7 @@ env: jobs: build-docker-cuda: - runs-on: ubuntu-18.04 + runs-on: linux.2xlarge strategy: matrix: cuda_version: ["11.8", "11.7", "11.6"] @@ -46,7 +46,7 @@ jobs: run: | manywheel/build_docker.sh build-docker-rocm: - runs-on: ubuntu-18.04 + runs-on: linux.2xlarge strategy: matrix: rocm_version: ["5.3", "5.4.2"] @@ -65,7 +65,7 @@ jobs: run: | manywheel/build_docker.sh build-docker-cpu: - runs-on: ubuntu-18.04 + runs-on: linux.2xlarge steps: - name: Checkout PyTorch uses: actions/checkout@v3 @@ -78,7 +78,7 @@ jobs: run: | manywheel/build_docker.sh build-docker-cpu-cxx11-abi: - runs-on: ubuntu-18.04 + runs-on: linux.2xlarge env: GPU_ARCH_TYPE: cpu-cxx11-abi steps: diff --git a/.github/workflows/build-nvidia-images.yml b/.github/workflows/build-nvidia-images.yml index d4a72fcf9..e854019dc 100644 --- a/.github/workflows/build-nvidia-images.yml +++ b/.github/workflows/build-nvidia-images.yml @@ -30,7 +30,7 @@ env: jobs: build-nvidia-docker: - runs-on: ubuntu-18.04 + runs-on: linux.2xlarge steps: - name: Build Nvidia Docker Image run: | From dd544e4302ae26934dae47e3acd48a2522fcd487 Mon Sep 17 00:00:00 2001 From: Huy Do Date: Mon, 6 Mar 2023 15:04:29 -0800 Subject: [PATCH 2/7] Leave build-nvidia-docker for now --- .github/workflows/build-nvidia-images.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-nvidia-images.yml b/.github/workflows/build-nvidia-images.yml index e854019dc..d4a72fcf9 100644 --- a/.github/workflows/build-nvidia-images.yml +++ b/.github/workflows/build-nvidia-images.yml @@ -30,7 +30,7 @@ env: jobs: build-nvidia-docker: - runs-on: linux.2xlarge + runs-on: ubuntu-18.04 steps: - name: Build Nvidia Docker Image run: | From bdc5745009c1d99119a7e388cd5abc730e4aaa78 Mon Sep 17 00:00:00 2001 From: Huy Do Date: Mon, 6 Mar 2023 19:06:44 -0800 Subject: [PATCH 3/7] Apply suggestions from code review Co-authored-by: Nikita Shulga --- .github/workflows/build-libtorch-images.yml | 2 +- .github/workflows/build-manywheel-images.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-libtorch-images.yml b/.github/workflows/build-libtorch-images.yml index 5d5e34bff..5bdb518db 100644 --- a/.github/workflows/build-libtorch-images.yml +++ b/.github/workflows/build-libtorch-images.yml @@ -25,7 +25,7 @@ env: jobs: build-docker-cuda: - runs-on: linux.2xlarge + runs-on: linux.large.ephemeral strategy: matrix: cuda_version: ["11.8", "11.7", "11.6"] diff --git a/.github/workflows/build-manywheel-images.yml b/.github/workflows/build-manywheel-images.yml index 2ae360a85..a8f66e022 100644 --- a/.github/workflows/build-manywheel-images.yml +++ b/.github/workflows/build-manywheel-images.yml @@ -27,7 +27,7 @@ env: jobs: build-docker-cuda: - runs-on: linux.2xlarge + runs-on: linux.c5.4xlarge.ephemeral strategy: matrix: cuda_version: ["11.8", "11.7", "11.6"] From 5fd0befa4af1f4909b6ee2e5c891ad54470e5fd8 Mon Sep 17 00:00:00 2001 From: Huy Do Date: Mon, 6 Mar 2023 19:11:59 -0800 Subject: [PATCH 4/7] Use ephemeral runners --- .github/workflows/build-conda-images.yml | 2 +- .github/workflows/build-libtorch-images.yml | 6 +++--- .github/workflows/build-magma-windows.yml | 2 +- .github/workflows/build-manywheel-images.yml | 6 +++--- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/build-conda-images.yml b/.github/workflows/build-conda-images.yml index 8104f8866..7d58df0f3 100644 --- a/.github/workflows/build-conda-images.yml +++ b/.github/workflows/build-conda-images.yml @@ -23,7 +23,7 @@ env: jobs: build-docker: - runs-on: linux.2xlarge + runs-on: linux.c5.4xlarge.ephemeral strategy: matrix: cuda_version: ["11.6", "11.7", "11.8", "cpu"] diff --git a/.github/workflows/build-libtorch-images.yml b/.github/workflows/build-libtorch-images.yml index 5bdb518db..eb67e5e70 100644 --- a/.github/workflows/build-libtorch-images.yml +++ b/.github/workflows/build-libtorch-images.yml @@ -25,7 +25,7 @@ env: jobs: build-docker-cuda: - runs-on: linux.large.ephemeral + runs-on: linux.c5.4xlarge.ephemeral strategy: matrix: cuda_version: ["11.8", "11.7", "11.6"] @@ -44,7 +44,7 @@ jobs: run: | libtorch/build_docker.sh build-docker-rocm: - runs-on: linux.2xlarge + runs-on: linux.c5.4xlarge.ephemeral strategy: matrix: rocm_version: ["5.3", "5.4.2"] @@ -63,7 +63,7 @@ jobs: run: | libtorch/build_docker.sh build-docker-cpu: - runs-on: linux.2xlarge + runs-on: linux.c5.4xlarge.ephemeral steps: - name: Checkout PyTorch uses: actions/checkout@v3 diff --git a/.github/workflows/build-magma-windows.yml b/.github/workflows/build-magma-windows.yml index 56d4cd3a6..dce6e9048 100644 --- a/.github/workflows/build-magma-windows.yml +++ b/.github/workflows/build-magma-windows.yml @@ -38,7 +38,7 @@ jobs: push-windows-magma: if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }} environment: magma - runs-on: linux.2xlarge + runs-on: linux.large.ephemeral needs: build-windows-magma steps: - name: Download all artifacts diff --git a/.github/workflows/build-manywheel-images.yml b/.github/workflows/build-manywheel-images.yml index a8f66e022..a3d8445e6 100644 --- a/.github/workflows/build-manywheel-images.yml +++ b/.github/workflows/build-manywheel-images.yml @@ -46,7 +46,7 @@ jobs: run: | manywheel/build_docker.sh build-docker-rocm: - runs-on: linux.2xlarge + runs-on: linux.c5.4xlarge.ephemeral strategy: matrix: rocm_version: ["5.3", "5.4.2"] @@ -65,7 +65,7 @@ jobs: run: | manywheel/build_docker.sh build-docker-cpu: - runs-on: linux.2xlarge + runs-on: linux.c5.4xlarge.ephemeral steps: - name: Checkout PyTorch uses: actions/checkout@v3 @@ -78,7 +78,7 @@ jobs: run: | manywheel/build_docker.sh build-docker-cpu-cxx11-abi: - runs-on: linux.2xlarge + runs-on: linux.c5.4xlarge.ephemeral env: GPU_ARCH_TYPE: cpu-cxx11-abi steps: From 835d35ed47a1f94be413a9ea53a82106c27e2195 Mon Sep 17 00:00:00 2001 From: Huy Do Date: Tue, 7 Mar 2023 11:00:35 -0800 Subject: [PATCH 5/7] Use ubuntu-latest --- .github/workflows/build-conda-images.yml | 2 +- .github/workflows/build-libtorch-images.yml | 6 +++--- .github/workflows/build-magma-windows.yml | 2 +- .github/workflows/build-manywheel-images.yml | 8 ++++---- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/build-conda-images.yml b/.github/workflows/build-conda-images.yml index 7d58df0f3..e90c32cea 100644 --- a/.github/workflows/build-conda-images.yml +++ b/.github/workflows/build-conda-images.yml @@ -23,7 +23,7 @@ env: jobs: build-docker: - runs-on: linux.c5.4xlarge.ephemeral + runs-on: ubuntu-latest strategy: matrix: cuda_version: ["11.6", "11.7", "11.8", "cpu"] diff --git a/.github/workflows/build-libtorch-images.yml b/.github/workflows/build-libtorch-images.yml index eb67e5e70..9b8a617e4 100644 --- a/.github/workflows/build-libtorch-images.yml +++ b/.github/workflows/build-libtorch-images.yml @@ -25,7 +25,7 @@ env: jobs: build-docker-cuda: - runs-on: linux.c5.4xlarge.ephemeral + runs-on: ubuntu-latest strategy: matrix: cuda_version: ["11.8", "11.7", "11.6"] @@ -44,7 +44,7 @@ jobs: run: | libtorch/build_docker.sh build-docker-rocm: - runs-on: linux.c5.4xlarge.ephemeral + runs-on: ubuntu-latest strategy: matrix: rocm_version: ["5.3", "5.4.2"] @@ -63,7 +63,7 @@ jobs: run: | libtorch/build_docker.sh build-docker-cpu: - runs-on: linux.c5.4xlarge.ephemeral + runs-on: ubuntu-latest steps: - name: Checkout PyTorch uses: actions/checkout@v3 diff --git a/.github/workflows/build-magma-windows.yml b/.github/workflows/build-magma-windows.yml index dce6e9048..8a9184f1d 100644 --- a/.github/workflows/build-magma-windows.yml +++ b/.github/workflows/build-magma-windows.yml @@ -38,7 +38,7 @@ jobs: push-windows-magma: if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }} environment: magma - runs-on: linux.large.ephemeral + runs-on: ubuntu-latest needs: build-windows-magma steps: - name: Download all artifacts diff --git a/.github/workflows/build-manywheel-images.yml b/.github/workflows/build-manywheel-images.yml index a3d8445e6..766a444d4 100644 --- a/.github/workflows/build-manywheel-images.yml +++ b/.github/workflows/build-manywheel-images.yml @@ -27,7 +27,7 @@ env: jobs: build-docker-cuda: - runs-on: linux.c5.4xlarge.ephemeral + runs-on: ubuntu-latest strategy: matrix: cuda_version: ["11.8", "11.7", "11.6"] @@ -46,7 +46,7 @@ jobs: run: | manywheel/build_docker.sh build-docker-rocm: - runs-on: linux.c5.4xlarge.ephemeral + runs-on: ubuntu-latest strategy: matrix: rocm_version: ["5.3", "5.4.2"] @@ -65,7 +65,7 @@ jobs: run: | manywheel/build_docker.sh build-docker-cpu: - runs-on: linux.c5.4xlarge.ephemeral + runs-on: ubuntu-latest steps: - name: Checkout PyTorch uses: actions/checkout@v3 @@ -78,7 +78,7 @@ jobs: run: | manywheel/build_docker.sh build-docker-cpu-cxx11-abi: - runs-on: linux.c5.4xlarge.ephemeral + runs-on: ubuntu-latest env: GPU_ARCH_TYPE: cpu-cxx11-abi steps: From 990c6d4f0faea8f04a7d0f3baa0e9a0b7f44e0da Mon Sep 17 00:00:00 2001 From: Huy Do Date: Thu, 16 Mar 2023 17:04:32 -0700 Subject: [PATCH 6/7] Apply suggestions from code review Co-authored-by: Nikita Shulga --- .github/workflows/build-libtorch-images.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-libtorch-images.yml b/.github/workflows/build-libtorch-images.yml index 9b8a617e4..49069557a 100644 --- a/.github/workflows/build-libtorch-images.yml +++ b/.github/workflows/build-libtorch-images.yml @@ -25,7 +25,7 @@ env: jobs: build-docker-cuda: - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 strategy: matrix: cuda_version: ["11.8", "11.7", "11.6"] @@ -44,7 +44,7 @@ jobs: run: | libtorch/build_docker.sh build-docker-rocm: - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 strategy: matrix: rocm_version: ["5.3", "5.4.2"] @@ -63,7 +63,7 @@ jobs: run: | libtorch/build_docker.sh build-docker-cpu: - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 steps: - name: Checkout PyTorch uses: actions/checkout@v3 From 6fb2185b7b6f202a00f39468c290d32b87f3fe04 Mon Sep 17 00:00:00 2001 From: Huy Do Date: Thu, 16 Mar 2023 17:06:55 -0700 Subject: [PATCH 7/7] Switch from latest to 22.04 to pin the version --- .github/workflows/build-conda-images.yml | 2 +- .github/workflows/build-magma-windows.yml | 2 +- .github/workflows/build-manywheel-images.yml | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/build-conda-images.yml b/.github/workflows/build-conda-images.yml index e90c32cea..43626533e 100644 --- a/.github/workflows/build-conda-images.yml +++ b/.github/workflows/build-conda-images.yml @@ -23,7 +23,7 @@ env: jobs: build-docker: - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 strategy: matrix: cuda_version: ["11.6", "11.7", "11.8", "cpu"] diff --git a/.github/workflows/build-magma-windows.yml b/.github/workflows/build-magma-windows.yml index 8a9184f1d..5ad6ba29a 100644 --- a/.github/workflows/build-magma-windows.yml +++ b/.github/workflows/build-magma-windows.yml @@ -38,7 +38,7 @@ jobs: push-windows-magma: if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }} environment: magma - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 needs: build-windows-magma steps: - name: Download all artifacts diff --git a/.github/workflows/build-manywheel-images.yml b/.github/workflows/build-manywheel-images.yml index 766a444d4..153f501bc 100644 --- a/.github/workflows/build-manywheel-images.yml +++ b/.github/workflows/build-manywheel-images.yml @@ -27,7 +27,7 @@ env: jobs: build-docker-cuda: - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 strategy: matrix: cuda_version: ["11.8", "11.7", "11.6"] @@ -46,7 +46,7 @@ jobs: run: | manywheel/build_docker.sh build-docker-rocm: - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 strategy: matrix: rocm_version: ["5.3", "5.4.2"] @@ -65,7 +65,7 @@ jobs: run: | manywheel/build_docker.sh build-docker-cpu: - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 steps: - name: Checkout PyTorch uses: actions/checkout@v3 @@ -78,7 +78,7 @@ jobs: run: | manywheel/build_docker.sh build-docker-cpu-cxx11-abi: - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 env: GPU_ARCH_TYPE: cpu-cxx11-abi steps: