From d669a520f08de8983ab4740e6f1400c2c3fa61f2 Mon Sep 17 00:00:00 2001 From: Vivek Miglani Date: Mon, 4 Dec 2023 06:03:11 -0800 Subject: [PATCH 1/5] Add extra tests --- .github/workflows/test-pip-cpu.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-pip-cpu.yml b/.github/workflows/test-pip-cpu.yml index b1e6028226..456f7119e3 100644 --- a/.github/workflows/test-pip-cpu.yml +++ b/.github/workflows/test-pip-cpu.yml @@ -12,12 +12,13 @@ jobs: tests: strategy: matrix: - pytorch_args: ["-v 1.6", "-v 1.7", " -v 1.8", "-v 1.9"] + pytorch_args: ["-v 1.6", "-v 1.7", " -v 1.8", "-v 1.9", "-v 1.10", "-v 1.11", " -v 1.12", " -v 1.13", " -v 2.0"] + docker_img: ["cimg/python:3.6", "cimg/python:3.7"] fail-fast: false uses: pytorch/test-infra/.github/workflows/linux_job.yml@main with: runner: linux.12xlarge - docker-image: cimg/python:3.6 + docker-image: ${{ matrix.docker_img }} repository: pytorch/captum script: | sudo chmod -R 777 . From 8aa51818d1c030005b747661b83f74de29885086 Mon Sep 17 00:00:00 2001 From: Vivek Miglani Date: Mon, 4 Dec 2023 06:19:49 -0800 Subject: [PATCH 2/5] Fix missing --- .github/workflows/test-pip-cpu.yml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test-pip-cpu.yml b/.github/workflows/test-pip-cpu.yml index 456f7119e3..e56868b7a2 100644 --- a/.github/workflows/test-pip-cpu.yml +++ b/.github/workflows/test-pip-cpu.yml @@ -12,8 +12,18 @@ jobs: tests: strategy: matrix: - pytorch_args: ["-v 1.6", "-v 1.7", " -v 1.8", "-v 1.9", "-v 1.10", "-v 1.11", " -v 1.12", " -v 1.13", " -v 2.0"] + pytorch_args: ["-v 1.6", "-v 1.7", " -v 1.8", "-v 1.9", "-v 1.10", "-v 1.11", " -v 1.12", " -v 1.13"] docker_img: ["cimg/python:3.6", "cimg/python:3.7"] + include: + - pytorch_args: " -v 2.0" + docker_img: "cimg/pytorch:3.8" + exclude: + - pytorch_args: "-v 1.11" + docker_img: "cimg/python:3.6" + - pytorch_args: "-v 1.12" + docker_img: "cimg/python:3.6" + - pytorch_args: "-v 1.13" + docker_img: "cimg/python:3.6" fail-fast: false uses: pytorch/test-infra/.github/workflows/linux_job.yml@main with: From 73ad9777670cbfd0a87debe3dad54d3cfef78668 Mon Sep 17 00:00:00 2001 From: Vivek Miglani Date: Mon, 4 Dec 2023 07:22:25 -0800 Subject: [PATCH 3/5] Fix indent --- .github/workflows/test-pip-cpu.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/test-pip-cpu.yml b/.github/workflows/test-pip-cpu.yml index e56868b7a2..5372b73573 100644 --- a/.github/workflows/test-pip-cpu.yml +++ b/.github/workflows/test-pip-cpu.yml @@ -15,15 +15,15 @@ jobs: pytorch_args: ["-v 1.6", "-v 1.7", " -v 1.8", "-v 1.9", "-v 1.10", "-v 1.11", " -v 1.12", " -v 1.13"] docker_img: ["cimg/python:3.6", "cimg/python:3.7"] include: - - pytorch_args: " -v 2.0" - docker_img: "cimg/pytorch:3.8" + - pytorch_args: " -v 2.0" + docker_img: "cimg/pytorch:3.8" exclude: - - pytorch_args: "-v 1.11" - docker_img: "cimg/python:3.6" - - pytorch_args: "-v 1.12" - docker_img: "cimg/python:3.6" - - pytorch_args: "-v 1.13" - docker_img: "cimg/python:3.6" + - pytorch_args: "-v 1.11" + docker_img: "cimg/python:3.6" + - pytorch_args: "-v 1.12" + docker_img: "cimg/python:3.6" + - pytorch_args: "-v 1.13" + docker_img: "cimg/python:3.6" fail-fast: false uses: pytorch/test-infra/.github/workflows/linux_job.yml@main with: From de0ec5dc1829cbaac1eb4cfd7272f584eec86c50 Mon Sep 17 00:00:00 2001 From: Vivek Miglani Date: Mon, 4 Dec 2023 07:22:57 -0800 Subject: [PATCH 4/5] Fix typo --- .github/workflows/test-pip-cpu.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-pip-cpu.yml b/.github/workflows/test-pip-cpu.yml index 5372b73573..0a6b6f424d 100644 --- a/.github/workflows/test-pip-cpu.yml +++ b/.github/workflows/test-pip-cpu.yml @@ -16,7 +16,7 @@ jobs: docker_img: ["cimg/python:3.6", "cimg/python:3.7"] include: - pytorch_args: " -v 2.0" - docker_img: "cimg/pytorch:3.8" + docker_img: "cimg/python:3.8" exclude: - pytorch_args: "-v 1.11" docker_img: "cimg/python:3.6" From a74ec0854477605c9b5686afb71ea064e68f8018 Mon Sep 17 00:00:00 2001 From: Vivek Miglani Date: Mon, 4 Dec 2023 11:10:33 -0800 Subject: [PATCH 5/5] Fix formatting --- .github/workflows/test-pip-cpu.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-pip-cpu.yml b/.github/workflows/test-pip-cpu.yml index 0a6b6f424d..1db8e5769b 100644 --- a/.github/workflows/test-pip-cpu.yml +++ b/.github/workflows/test-pip-cpu.yml @@ -12,10 +12,10 @@ jobs: tests: strategy: matrix: - pytorch_args: ["-v 1.6", "-v 1.7", " -v 1.8", "-v 1.9", "-v 1.10", "-v 1.11", " -v 1.12", " -v 1.13"] + pytorch_args: ["-v 1.6", "-v 1.7", "-v 1.8", "-v 1.9", "-v 1.10", "-v 1.11", "-v 1.12", "-v 1.13"] docker_img: ["cimg/python:3.6", "cimg/python:3.7"] include: - - pytorch_args: " -v 2.0" + - pytorch_args: "-v 2.0" docker_img: "cimg/python:3.8" exclude: - pytorch_args: "-v 1.11"