Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add datapipes deprecation warning banner to docs #1312

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Add datapipes deprecation warning banner to docs #1312

merged 1 commit into from
Aug 7, 2024

Conversation

andrewkho
Copy link
Contributor

@andrewkho andrewkho commented Aug 7, 2024 •
edited
Loading

Changes

  • add deprecation banner to sphinx docs. Adding this in rst_prolog pre-pends it to every page

Tested by building locally
image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 7, 2024
@andrewkho
Copy link
Contributor Author

  • merge and deploy main docs
  • Cherry pick to 0.8.0 and deploy 0.8.0 docs

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 7, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1312

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit ccc3580 with merge base 88c8bdc (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

gokulavasan
gokulavasan approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@gokulavasan gokulavasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg!

@andrewkho
Copy link
Contributor Author

AIStore failures seem unrelated, some type error in underlying library

@andrewkho andrewkho merged commit f1d41c7 into main Aug 7, 2024
62 of 66 checks passed
@andrewkho andrewkho deleted the andrewkh/add-deprecation-to-docs branch August 7, 2024 22:10
andrewkho added a commit that referenced this pull request Aug 7, 2024
@andrewkho
Add datapipes deprecation warning banner to docs (#1312)
131349b 
Co-authored-by: Andrew Ho <andrewkh@fb.com>
andrewkho added a commit that referenced this pull request Aug 8, 2024
@andrewkho
Add datapipes deprecation warning banner to docs (#1312) (#1313)
37a1426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gokulavasan gokulavasan gokulavasan approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewkho @gokulavasan @facebook-github-bot