Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Fix broken windows build (#1320) #1323

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

andrewkho
Copy link
Contributor

Cherry pick #1320 to release branch

---------

Co-authored-by: andrewkh <andrewkh@devgpu003.cco1.facebook.com>
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 26, 2024
@andrewkho andrewkho changed the title Fix broken windows build (#1320) [Release] Fix broken windows build (#1320) Sep 26, 2024
Copy link

pytorch-bot bot commented Sep 26, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1323

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2cc3219 with merge base a629426 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link

@divyanshk divyanshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewkho andrewkho merged commit 40970d2 into release/0.9 Sep 26, 2024
70 checks passed
@andrewkho andrewkho deleted the andrewkh/cherry-pick-windows-fix branch September 26, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants