Use 4x3 tiled shader for linear mat mul which performs slightly better. #15988
+25
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15988
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 183c8ef with merge base 3ce840c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@trivedivivek has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87902847. |
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Nov 26, 2025
…r. (pytorch#15988) Summary: This diff optimizes the performance of the quantized linear matrix multiplication operation by using a 4x3 tiled shader, which performs slightly better than the previous implementation. Differential Revision: D87902847
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Nov 26, 2025
…r. (pytorch#15988) Summary: This diff optimizes the performance of the quantized linear matrix multiplication operation by using a 4x3 tiled shader, which performs slightly better than the previous implementation. Differential Revision: D87902847
trivedivivek
added
the
release notes: vulkan
yipjustin
approved these changes
Nov 26, 2025
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Nov 26, 2025
…r. (pytorch#15988) Summary: This diff optimizes the performance of the quantized linear matrix multiplication operation by using a 4x3 tiled shader, which performs slightly better than the previous implementation. Reviewed By: yipjustin Differential Revision: D87902847
trivedivivek
force-pushed
the
export-D87902847
branch
from
2a2fa9a to
ef53422
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Nov 26, 2025
…r. (pytorch#15988) Summary: This diff optimizes the performance of the quantized linear matrix multiplication operation by using a 4x3 tiled shader, which performs slightly better than the previous implementation. Reviewed By: yipjustin Differential Revision: D87902847
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Nov 26, 2025
…r. (pytorch#15988) Summary: This diff optimizes the performance of the quantized linear matrix multiplication operation by using a 4x3 tiled shader, which performs slightly better than the previous implementation. Reviewed By: yipjustin Differential Revision: D87902847
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Nov 26, 2025
…r. (pytorch#15988) Summary: This diff optimizes the performance of the quantized linear matrix multiplication operation by using a 4x3 tiled shader, which performs slightly better than the previous implementation. Reviewed By: yipjustin Differential Revision: D87902847
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Nov 26, 2025
…r. (pytorch#15988) Summary: This diff optimizes the performance of the quantized linear matrix multiplication operation by using a 4x3 tiled shader, which performs slightly better than the previous implementation. Reviewed By: yipjustin Differential Revision: D87902847
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Dec 1, 2025
…r. (pytorch#15988) Summary: This diff optimizes the performance of the quantized linear matrix multiplication operation by using a 4x3 tiled shader, which performs slightly better than the previous implementation. Reviewed By: yipjustin Differential Revision: D87902847
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Dec 1, 2025
…r. (pytorch#15988) Summary: This diff optimizes the performance of the quantized linear matrix multiplication operation by using a 4x3 tiled shader, which performs slightly better than the previous implementation. Reviewed By: yipjustin Differential Revision: D87902847
trivedivivek
force-pushed
the
export-D87902847
branch
from
ef53422 to
45ea9d8
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Dec 1, 2025
…r. (pytorch#15988) Summary: This diff optimizes the performance of the quantized linear matrix multiplication operation by using a 4x3 tiled shader, which performs slightly better than the previous implementation. Reviewed By: yipjustin Differential Revision: D87902847
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Dec 1, 2025
…r. (pytorch#15988) Summary: This diff optimizes the performance of the quantized linear matrix multiplication operation by using a 4x3 tiled shader, which performs slightly better than the previous implementation. Reviewed By: yipjustin Differential Revision: D87902847
trivedivivek
force-pushed
the
export-D87902847
branch
from
45ea9d8 to
d9c2059
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Dec 1, 2025
…r. (pytorch#15988) Summary: This diff optimizes the performance of the quantized linear matrix multiplication operation by using a 4x3 tiled shader, which performs slightly better than the previous implementation. Reviewed By: yipjustin Differential Revision: D87902847
trivedivivek
force-pushed
the
export-D87902847
branch
from
d9c2059 to
1dc0e0d
Compare
…r. (pytorch#15988) Summary: This diff optimizes the performance of the quantized linear matrix multiplication operation by using a 4x3 tiled shader, which performs slightly better than the previous implementation. Reviewed By: yipjustin Differential Revision: D87902847
trivedivivek
force-pushed
the
export-D87902847
branch
from
1dc0e0d to
183c8ef
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Dec 1, 2025
…r. (pytorch#15988) Summary: This diff optimizes the performance of the quantized linear matrix multiplication operation by using a 4x3 tiled shader, which performs slightly better than the previous implementation. Reviewed By: yipjustin Differential Revision: D87902847
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Dec 1, 2025
…r. (pytorch#15988) Summary: This diff optimizes the performance of the quantized linear matrix multiplication operation by using a 4x3 tiled shader, which performs slightly better than the previous implementation. Reviewed By: yipjustin Differential Revision: D87902847
AdrianLundell
pushed a commit
to AdrianLundell/executorch
that referenced
this pull request
Dec 2, 2025
Differential Revision: D87902847 Pull Request resolved: pytorch#15988
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff optimizes the performance of the quantized linear matrix multiplication operation by using a 4x3 tiled shader, which performs slightly better than the previous implementation.
Differential Revision: D87902847