From 48fa78dc5be66d9887407518dbcf722dfe96e978 Mon Sep 17 00:00:00 2001 From: Harish Srinivas Date: Fri, 7 Mar 2025 07:08:55 -0800 Subject: [PATCH] Remove explicit descriptor (#9001) Summary: we only need this for constructors with one param Reviewed By: JacobSzwejbka Differential Revision: D70630711 --- extension/training/optimizer/sgd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/extension/training/optimizer/sgd.h b/extension/training/optimizer/sgd.h index 055d561287d..b3e58ea8d8e 100644 --- a/extension/training/optimizer/sgd.h +++ b/extension/training/optimizer/sgd.h @@ -179,7 +179,7 @@ class ET_EXPERIMENTAL SGDParamGroup { */ class ET_EXPERIMENTAL SGD { public: - explicit SGD( + SGD( const std::vector& param_groups, SGDOptions defaults) : defaults_(std::make_unique(defaults)) { @@ -188,7 +188,7 @@ class ET_EXPERIMENTAL SGD { } } - explicit SGD( + SGD( const std::map& named_parameters, SGDOptions defaults)