Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up previous runs from GPU runner #2676

Merged
merged 4 commits into from
Oct 4, 2023
Merged

Cleaning up previous runs from GPU runner #2676

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
447b370
Cleaning up previous runner
agunapal Oct 4, 2023
cd1b879
Cleaning up previous runner
agunapal Oct 4, 2023
654d125
Cleaning up previous runner
agunapal Oct 4, 2023
5eca608
added comments
agunapal Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/ci_gpu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,10 @@ jobs:
- name: Clean up previous run
run: |
echo "Cleaning up previous run"
cd $RUNNER_WORKSPACE
pwd
cd ..
pwd
rm -rf _tool
ls -la ./
sudo rm -rf ./* || true
sudo rm -rf ./.??* || true
ls -la ./
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need specify the path and then delete

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work https://github.com/pytorch/serve/actions/runs/6409297939

Also, we have been doing the same in Regression GPU runners and it works

https://github.com/pytorch/serve/blob/master/.github/workflows/regression_tests_gpu.yml#L21

Copy link
Member

@msaroufim msaroufim Oct 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you maybe add a comment to more explicitly say what this is trying to achieve? As in which files are folders are you targeting for cleanup

The benefit of not having * in remove commands is we can be more explicit about what's being deleted

- name: Setup Python 3.8
uses: actions/setup-python@v4
with:
Expand Down