This repository was archived by the owner on Aug 1, 2025. It is now read-only.
turn off normalize_ir, turn on use_functionalization by default #1050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chillee
approved these changes
Aug 26, 2022
Contributor
|
If you are talking about marking 6 new failing model to the CI skip list, you can wait for my #1040 to land. Also did you test on hf and timm as well? |
ezyang
approved these changes
Aug 26, 2022
Contributor
Author
|
@desertfire thanks, I'll wait for your PR to land and add to the skip list.
Yep - I ran the hf and timm benchmarks locally with the before and after, as a sanity check that functionalization isn't regressing a large number of models. I'm not 100% confident in my results (a few models didn't run at all for some reason), but I counted a total of 8 new failures from HF, and 4 new failures from timm. Once this PR lands I'll work on triaging the failures and making issues for them. |
bdhirsh
commented
Aug 26, 2022
bdhirsh
force-pushed
the
turn_on_only_functionalization2
branch
from
b9afe9d to
98e1fd8
Compare
Contributor
Author
|
looks like CI is getting rate limited |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fresh PR without ghstack. Before landing, I still need to
(1) rebase on top of #1048
(2) mark the 6 new failing models as skips (and create issues tracking them)