From 3fe45dc1873f9cef060fdfe784b3dba88a045a8c Mon Sep 17 00:00:00 2001 From: Tushar Jain Date: Mon, 28 Jul 2025 11:34:30 -0700 Subject: [PATCH] remove dead code Summary: remove some stale code that determines parameters to pass to outer optimizer --- torchtitan/components/ft.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/torchtitan/components/ft.py b/torchtitan/components/ft.py index 70b814f3aa..76f2da3ae5 100644 --- a/torchtitan/components/ft.py +++ b/torchtitan/components/ft.py @@ -123,8 +123,6 @@ def maybe_semi_sync_training( ), "FTManager must be enabled to use semi-sync training." if semi_sync_method.lower() == "diloco": # Create the outer optimizer based on the inner optimizer parameters. - params = [group["params"] for group in optimizer.param_groups] - params = [param for sublist in params for param in sublist] outer_optimizers = [] for model in model_parts: params = [p for p in model.parameters() if p.requires_grad]