Skip to content

remove dead code #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
Merged

remove dead code #1501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions torchtitan/components/ft.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,6 @@ def maybe_semi_sync_training(
), "FTManager must be enabled to use semi-sync training."
if semi_sync_method.lower() == "diloco":
# Create the outer optimizer based on the inner optimizer parameters.
params = [group["params"] for group in optimizer.param_groups]
params = [param for sublist in params for param in sublist]
outer_optimizers = []
for model in model_parts:
params = [p for p in model.parameters() if p.requires_grad]
Expand Down
Loading