Minor fixes in simple_fsdp experiments #1853
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
yiming0416
force-pushed
the
fix_simple_fsdp_train_spec
branch
from
0d75b04 to
541d08b
Compare
yiming0416
changed the title
yiming0416
force-pushed
the
fix_simple_fsdp_train_spec
branch
from
541d08b to
9cddf26
Compare
ruisizhang123
approved these changes
Oct 11, 2025
Contributor
ruisizhang123
left a comment
ruisizhang123
left a comment
There was a problem hiding this comment.
LGTM, thank you for the fix.
githubsgi
pushed a commit
to githubsgi/torchtitan
that referenced
this pull request
Oct 13, 2025
pytorch#1850 removed `name` field in `TrainSpec`. The experiments in simple_fsdp should also be updated. Otherwise it won't run. pytorch#1776 added `use_flex_attn` field to `apply_non_moe_tp()`, which is missing in simple_fsdp experiments ``` NGPU=8 CONFIG_FILE=./torchtitan/models/llama3/train_configs/debug_model.toml ./run_train.sh --model.name simple_fsdp.llama3 --compile.enable ``` ``` NGPU=8 CONFIG_FILE=./torchtitan/models/deepseek_v3/train_configs/debug_model.toml ./run_train.sh --model.name simple_fsdp.deepseek_v3 --compile.enable ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1850 removed
namefield inTrainSpec. The experiments in simple_fsdp should also be updated. Otherwise it won't run.#1776 added
use_flex_attnfield toapply_non_moe_tp(), which is missing in simple_fsdp experiments