[refactor] graduate custom_config_module and unify args/config naming #1871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianyu-l
requested review from
allenwang28,
ebsmothers,
fegin,
joecummings,
pbontrager,
wconstab and
wwwjn
as code owners
meta-cla
bot
added
the
CLA Signed
This was referenced Oct 14, 2025
tianyu-l
force-pushed
the
job_config
branch
2 times, most recently
from
ae38610 to
60295cb
Compare
wwwjn
approved these changes
Oct 14, 2025
Contributor
wwwjn
left a comment
wwwjn
left a comment
There was a problem hiding this comment.
LGTM! Please fix minor issues
tianyu-l
commented
Oct 14, 2025
githubsgi
pushed a commit
to githubsgi/torchtitan
that referenced
this pull request
Oct 15, 2025
…pytorch#1871) In the past, the terms "args" and "config" have been used in a mix. To make it unambiguous, in torchtitan we use - "args" as in `ModelArgs` to refer to parameters used to define a model in model code - "config" as in `JobConfig` to refer to configurable training job commands used in training script This also PR also moves `custom_args_module` (which should be `custom_config_module` according to the naming rule above) from `Experimental` to `Job`, as it has been extensively used by various models in torchtitan, especially those in the `experiments` folder.
githubsgi
pushed a commit
to githubsgi/torchtitan
that referenced
this pull request
Oct 16, 2025
…pytorch#1871) In the past, the terms "args" and "config" have been used in a mix. To make it unambiguous, in torchtitan we use - "args" as in `ModelArgs` to refer to parameters used to define a model in model code - "config" as in `JobConfig` to refer to configurable training job commands used in training script This also PR also moves `custom_args_module` (which should be `custom_config_module` according to the naming rule above) from `Experimental` to `Job`, as it has been extensively used by various models in torchtitan, especially those in the `experiments` folder.
githubsgi
pushed a commit
to githubsgi/torchtitan
that referenced
this pull request
Oct 29, 2025
…pytorch#1871) In the past, the terms "args" and "config" have been used in a mix. To make it unambiguous, in torchtitan we use - "args" as in `ModelArgs` to refer to parameters used to define a model in model code - "config" as in `JobConfig` to refer to configurable training job commands used in training script This also PR also moves `custom_args_module` (which should be `custom_config_module` according to the naming rule above) from `Experimental` to `Job`, as it has been extensively used by various models in torchtitan, especially those in the `experiments` folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, the terms "args" and "config" have been used in a mix.
To make it unambiguous, in torchtitan we use
ModelArgsto refer to parameters used to define a model in model codeJobConfigto refer to configurable training job commands used in training scriptThis also PR also moves
custom_args_module(which should becustom_config_moduleaccording to the naming rule above) fromExperimentaltoJob, as it has been extensively used by various models in torchtitan, especially those in theexperimentsfolder.