[FSDP2] LoRA/QLoRA move state dict to cpu #1531
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1531
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bc780ff with merge base 66590b4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1531 +/- ##
==========================================
- Coverage 27.22% 27.20% -0.02%
==========================================
Files 286 286
Lines 13828 13828
==========================================
- Hits 3764 3762 -2
- Misses 10064 10066 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up on #1412
FSDP2 will throw error with to remind user to move parameters to cpu when enabling cpu offloading: pytorch/pytorch#135156
Chaging torchtune LoRA/QLoRA to load from cpu state dict when enabling cpu offloading. This makes sure pytorch nightly does not break LoRA/QLoRA
Context
What is the purpose of this PR? Is it to