Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not review - llama 3 and 2 instantiate pos emb only once #1556

Open
wants to merge 51 commits into
base: main
Choose a base branch
from

Conversation

felipemello1
Copy link
Contributor

@felipemello1 felipemello1 commented Sep 12, 2024

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

same as in: #1554

Changelog

  • llama 2 module list
  • llama 3 module list

Test plan

no memory gains because fsdp nproc=8, so its 2GiB/8

tune run --nnodes 1 --nproc_per_node 8 lora_finetune_distributed --config llama2/7B_lora batch_size=8 max_steps_per_epoch=20 metric_logger=torchtune.training.metric_logging.WandBLogger gradient_accumulation_steps=1 epochs=1 compile=True log_peak_memory_stats=True
image
tune run --nnodes 1 --nproc_per_node 8 lora_finetune_distributed --config llama2/7B_lora batch_size=8 max_steps_per_epoch=20 metric_logger=torchtune.training.metric_logging.WandBLogger gradient_accumulation_steps=1 epochs=1 compile=True log_peak_memory_stats=True
image

Copy link

pytorch-bot bot commented Sep 12, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1556

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Cancelled Job

As of commit 9d7347f with merge base 7dad2d6 (image):

NEW FAILURES - The following jobs have failed:

  • GPU tests / gpu_test (3.10, stable) (gh)
    tests/recipes/test_ppo_full_finetune_single_device.py::TestPPOFullFinetuneSingleDeviceRecipe::test_training_state_on_resume_with_optimizer_in_bwd
  • GPU tests / gpu_test (3.11, stable) (gh)
    tests/recipes/test_ppo_full_finetune_single_device.py::TestPPOFullFinetuneSingleDeviceRecipe::test_training_state_on_resume_with_optimizer_in_bwd

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2024
Felipe Mello added 23 commits September 12, 2024 11:19
This reverts commit a2d6ef7.
This reverts commit 1a6d458.
This reverts commit a8214e0.
@felipemello1 felipemello1 changed the title 4/n - llama 3 and llama2 instantiate pos embedding only once do not review - llama 3 and 2 instantiate pos emb only once Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants