-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not review - llama 3 and 2 instantiate pos emb only once #1556
Open
felipemello1
wants to merge
51
commits into
pytorch:main
Choose a base branch
from
felipemello1:update_llama3_and_2_modulelist
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
do not review - llama 3 and 2 instantiate pos emb only once #1556
felipemello1
wants to merge
51
commits into
pytorch:main
from
felipemello1:update_llama3_and_2_modulelist
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1556
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Cancelled JobAs of commit 9d7347f with merge base 7dad2d6 (): NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Sep 12, 2024
…ate_tied_transformer
This reverts commit 930459e.
This reverts commit 47bbc30.
This reverts commit 2c6a40a.
This reverts commit a2d6ef7.
This reverts commit 50af9ac.
…3_and_2_modulelist
This reverts commit 1a6d458.
This reverts commit a8214e0.
This reverts commit f7bbc13.
This reverts commit 9a327d4.
This reverts commit 26a8216.
felipemello1
changed the title
4/n - llama 3 and llama2 instantiate pos embedding only once
do not review - llama 3 and 2 instantiate pos emb only once
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
What is the purpose of this PR? Is it to
same as in: #1554
Changelog
Test plan
no memory gains because fsdp nproc=8, so its 2GiB/8