Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add low_cpu_ram config to qlora recipes configs (excluding 2B/13B/70B configs) #1580

Merged
merged 6 commits into from
Sep 26, 2024

Conversation

mikaylagawarecki
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki commented Sep 13, 2024

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

Addresses this comment https://github.com/pytorch/torchtune/pull/1315/files#r1750554790

Changelog

What are the changes made in this PR?
Update all qlora recipes to have low_cpu_ram config option added in #1315

Test plan

colab notebook https://colab.research.google.com/drive/14fGovrKguuTh67T0eL_rIg7gmJVaYSie?usp=sharing that tests checkpoint save with and without low_cpu_ram and verifies that with low_cpu_ram=True all of the qlora recipes updated here no longer OOM on checkpoint save.

Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.)

  • run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • run unit tests via pytest tests
  • run recipe tests via pytest tests -m integration_test
  • manually run any new or modified recipes with sufficient proof of correctness
  • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX

If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Example of docstring:


Example in our docs: https://pytorch.org/torchtune/main/tutorials/qat_finetune.html#applying-qat-to-llama3-models

  • I did not change any public API;
  • I have added an example to docs or docstrings;

Copy link

pytorch-bot bot commented Sep 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1580

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 38b274d with merge base ee343e6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 13, 2024
@mikaylagawarecki mikaylagawarecki changed the title Add low_cpu_ram config to all qlora recipes configs Add low_cpu_ram config to 7-8B qlora recipes configs Sep 13, 2024
@mikaylagawarecki mikaylagawarecki changed the title Add low_cpu_ram config to 7-8B qlora recipes configs Add low_cpu_ram config to qlora recipes configs (excluding 2B/13B/70B configs) Sep 13, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 71.05%. Comparing base (ee343e6) to head (38b274d).

Files with missing lines Patch % Lines
torchtune/models/mistral/_component_builders.py 33.33% 2 Missing ⚠️
torchtune/models/gemma/_component_builders.py 50.00% 1 Missing ⚠️
torchtune/models/llama2/_component_builders.py 66.66% 1 Missing ⚠️
torchtune/models/llama3_1/_component_builders.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1580      +/-   ##
==========================================
- Coverage   73.08%   71.05%   -2.03%     
==========================================
  Files         289      289              
  Lines       14157    14170      +13     
==========================================
- Hits        10346    10068     -278     
- Misses       3811     4102     +291     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joecummings
Copy link
Contributor

@ebsmothers

Copy link
Contributor

@ebsmothers ebsmothers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay in getting to this one. This looks great!

@ebsmothers ebsmothers merged commit 98985e4 into pytorch:main Sep 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants