rename confusing variable name in LM tutorial #1953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-tutorials-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
The tutorial "Language Modeling with nn.Transformer and TorchText" contains code snippets with variables named `batch_size`. The issue is that in some places, `batch_size` means that number of sequences in a batch, and in other places it means the number of tokens in each batch sequence. This inconsistency was solved in this commit: `batch_size` was replaced with `seq_len` in the two places where it has the latter meaning.
zhangguanheng66
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tutorial "Language Modeling with nn.Transformer and TorchText" contains
code snippets with variables named
batch_size. The issue is that in someplaces,
batch_sizemeans that number of sequences in a batch, and in otherplaces it means the number of tokens in each batch sequence. This inconsistency
was solved in this commit:
batch_sizewas replaced withseq_lenin the twoplaces where it has the latter meaning.