From 3b5c895c4a8e47eb5739d26efcf5c930358beb29 Mon Sep 17 00:00:00 2001 From: Andrey Talman Date: Mon, 16 Dec 2024 14:07:56 -0500 Subject: [PATCH 1/4] Update build-wheels-windows.yml --- .github/workflows/build-wheels-windows.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-wheels-windows.yml b/.github/workflows/build-wheels-windows.yml index a269aea2604..86b27d7e926 100644 --- a/.github/workflows/build-wheels-windows.yml +++ b/.github/workflows/build-wheels-windows.yml @@ -2,6 +2,8 @@ name: Build Windows Wheels on: pull_request: + paths: + - .github/workflows/build-wheels-windows.yml push: branches: - nightly @@ -19,7 +21,7 @@ permissions: jobs: generate-matrix: - uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@main + uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@test-ninja-build with: package-type: wheel os: windows @@ -39,7 +41,7 @@ jobs: smoke-test-script: test/smoke_test.py package-name: torchvision name: ${{ matrix.repository }} - uses: pytorch/test-infra/.github/workflows/build_wheels_windows.yml@main + uses: pytorch/test-infra/.github/workflows/build_wheels_windows.yml@test-ninja-build with: repository: ${{ matrix.repository }} ref: "" From 431199da768ce9ca313aab3302eca7719b3c735a Mon Sep 17 00:00:00 2001 From: Andrey Talman Date: Mon, 16 Dec 2024 14:20:42 -0500 Subject: [PATCH 2/4] Update pre_build_script.sh --- packaging/pre_build_script.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/pre_build_script.sh b/packaging/pre_build_script.sh index 6bc3cdc703f..eefe5415e43 100644 --- a/packaging/pre_build_script.sh +++ b/packaging/pre_build_script.sh @@ -38,5 +38,5 @@ else pip install auditwheel fi -pip install numpy pyyaml future ninja +pip install numpy pyyaml future pip install --upgrade setuptools==72.1.0 From f9a993962b8421038a3edbf3e7a3b087da3c58fb Mon Sep 17 00:00:00 2001 From: Andrey Talman Date: Mon, 16 Dec 2024 15:50:47 -0500 Subject: [PATCH 3/4] Update pre_build_script.sh --- packaging/pre_build_script.sh | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/packaging/pre_build_script.sh b/packaging/pre_build_script.sh index eefe5415e43..1d1e1e0a2af 100644 --- a/packaging/pre_build_script.sh +++ b/packaging/pre_build_script.sh @@ -24,6 +24,11 @@ if [[ "$(uname)" == Darwin || "$OSTYPE" == "msys" ]]; then python_exec="$(which python)" bin_path=$(dirname $python_exec) cp "$bin_path/Library/bin/libjpeg.dll" torchvision + + # issue with Building torchvision on py3.13 + if[[ "$PYTHON_VERSION" == 3.13 ]]; then + mkdir -p build\\temp.win-amd64-cpython-313\\Release + fi fi else From ae238682d7170e3703a84a426b774dad1fbb9ffe Mon Sep 17 00:00:00 2001 From: Andrey Talman Date: Mon, 16 Dec 2024 15:51:07 -0500 Subject: [PATCH 4/4] Update pre_build_script.sh --- packaging/pre_build_script.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/pre_build_script.sh b/packaging/pre_build_script.sh index 1d1e1e0a2af..db62eb5862e 100644 --- a/packaging/pre_build_script.sh +++ b/packaging/pre_build_script.sh @@ -26,7 +26,7 @@ if [[ "$(uname)" == Darwin || "$OSTYPE" == "msys" ]]; then cp "$bin_path/Library/bin/libjpeg.dll" torchvision # issue with Building torchvision on py3.13 - if[[ "$PYTHON_VERSION" == 3.13 ]]; then + if [[ "$PYTHON_VERSION" == 3.13 ]]; then mkdir -p build\\temp.win-amd64-cpython-313\\Release fi fi