Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyTorch/XLA Codegen Migration #3560

Open
wonjoolee95 opened this issue May 10, 2022 · 0 comments · Fixed by #3544, #3565, #3574, #3575 or #3576
Open

PyTorch/XLA Codegen Migration #3560

wonjoolee95 opened this issue May 10, 2022 · 0 comments · Fixed by #3544, #3565, #3574, #3575 or #3576
Assignees
@miladm @ysiraichi
Labels
codegen
Milestone
Lazy Tensor Core ...

Comments

@wonjoolee95
Copy link
Collaborator

wonjoolee95 commented May 10, 2022 •
edited
Loading

🚀 Feature

As PyTorch/XLA migrates to the LTC (Lazy Tensor Core), we need to clean up the existing stub code (which spans over 6+ files) that were used to do the op lowering. The complete process and file structure for the old op lowering can be found in this doc. Replacing the supported op with the codegen SHOULD NOT introduce any new behavior, it is purely for the clean up purpose.

TODO migrate @JackCaoG's codegen guide doc to a publicly available .md in the repo.

Ops

List of ops that we will replace with full codgen. Please add the following information under each op that you choose to work on: the status of the task, link to the PR, and the owner. For example:

  - Status: Merged
  - PR: https://github.com/pytorch/xla/pull/3565
  - Owner: @wonjoolee95

Once the corresponding PR is merged, feel free to check the box to mark completion.

Won't do's

This contains a list of ops that are not suitable for full codegen at the moment. Please list the op and the corresponding reason.
This was linked to pull requests May 17, 2022
Full codegen for log, log2, and log10 #3573
Closed
Lower celu, celu_, selu, and selu_ #3547
Merged
@miladm miladm removed a link to a pull request May 17, 2022
Lower celu, celu_, selu, and selu_ #3547
Merged
This was linked to pull requests May 17, 2022
Codegen Abs and Maximum op #3544
Merged
Full codegen asin, asinh, atan, and atanh #3565
Merged
Codegen acos and acosh #3563
Closed
Full codegen for cos and cosh #3574
Merged
Full codegen for Inverse #3575
Merged
Full codegen for logdet #3576
Merged
Full codegen for sgn, sign #3577
Merged
@miladm miladm added the codegen label May 17, 2022
@wonjoolee95 wonjoolee95 reopened this May 18, 2022
@miladm miladm reopened this Jun 8, 2022
@yeounoh yeounoh self-assigned this Jul 6, 2022
@miladm miladm mentioned this issue Jul 13, 2022
Closed
@li-yi-dong li-yi-dong mentioned this issue Jul 22, 2022
Merged
@ManfeiBai ManfeiBai mentioned this issue Nov 7, 2022
Closed
@miladm miladm mentioned this issue Jan 18, 2024
Merged
This was referenced Aug 15, 2024
Closed
Closed
Closed
Closed
Closed
@wonjoolee95 wonjoolee95 removed their assignment Aug 15, 2024
This was referenced Aug 15, 2024
Closed
Closed
@miladm miladm assigned ysiraichi and unassigned JackCaoG Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miladm miladm

@ysiraichi ysiraichi

Labels
codegen
Projects
None yet
Milestone
Lazy Tensor Core (LTC) Upstreaming
5 participants
@miladm @ysiraichi @yeounoh @wonjoolee95 @JackCaoG