Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: mypy checklist #151

Merged
merged 3 commits into from
Mar 5, 2022
Merged

MNT: mypy checklist #151

merged 3 commits into from
Mar 5, 2022

Conversation

GuillaumeFavelier
Copy link
Contributor

@GuillaumeFavelier GuillaumeFavelier commented Mar 5, 2022

This PR adds a checklist file to mypy to go around the issue we encounter with exclude in #149.

Related to python/mypy#11760

@GuillaumeFavelier GuillaumeFavelier self-assigned this Mar 5, 2022
@codecov
Copy link

codecov bot commented Mar 5, 2022

Codecov Report

Merging #151 (9a03485) into main (698d729) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   97.87%   97.87%           
=======================================
  Files           8        8           
  Lines         658      658           
=======================================
  Hits          644      644           
  Misses         14       14           

@GuillaumeFavelier
Copy link
Contributor Author

This is ready to go from my end @pyvista/pyvistaqt-admin

@larsoner larsoner merged commit 8826078 into pyvista:main Mar 5, 2022
@larsoner
Copy link
Contributor

larsoner commented Mar 5, 2022

Thanks @GuillaumeFavelier !

@GuillaumeFavelier GuillaumeFavelier deleted the mnt/mypy branch March 5, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants