Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests #21

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Integration tests #21

merged 1 commit into from
Feb 27, 2024

Conversation

wvengen
Copy link
Member

@wvengen wvengen commented Feb 15, 2024

  • Add initial tests
  • CI for Docker (running locally)
  • CI for Kubernetes (running locally)
  • Fix jobs on Kubernetes CI being stuck in scheduled
  • CI for running scrapyd-k8s in Kubernetes (testing kubernetes.yaml)
  • Add spider to example spider project that returns static data (or run from cache)
  • Finish tests --> as part of other issues

Possible next steps:

  • Test job cancel while job is pending (needs something to create a job without starting it)
  • Test http auth (needs config file change and daemon restart, so perhaps different method)
  • Test if values in secret and configmap are passed through to the spider (*)
  • Test if pull secret is picked up
  • Test if schedule spider arguments are passed through to the spider (*)
  • Test if schedule spider settings are passed through to the spider (*)

(*) May need changes to the example spider, e.g. returning ENV, spider settings and spider arguments in static spider or a new debug spider or so.

@wvengen wvengen force-pushed the feature/7-integration-tests branch 10 times, most recently from 57c8154 to 13c1198 Compare February 15, 2024 15:50
@wvengen wvengen force-pushed the feature/7-integration-tests branch 12 times, most recently from 5b97c62 to 2ff2501 Compare February 16, 2024 08:27
@wvengen wvengen marked this pull request as ready for review February 16, 2024 08:38
@wvengen wvengen requested a review from vlerkin February 16, 2024 08:43
- Integration tests for the scrapyd-k8s API
- Run against Docker and Kubernetes
- Deploy sample manifest in minikube and run integration tests there

The integration tests can still be improved and expanded.
Copy link
Collaborator

@vlerkin vlerkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, nicely done! Also very valuable for me to learn this level of testing:)

@wvengen wvengen merged commit 1e0fda4 into main Feb 27, 2024
4 checks passed
@wvengen wvengen deleted the feature/7-integration-tests branch February 27, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants