Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: datavalidation list error, formula > 255 issue #339 #340

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

rentiansheng
Copy link
Contributor

PR Details

close #339

Description

datavalidation list error, formula > 255, not set formula value

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [-] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [-] I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-io
Copy link

codecov-io commented Jan 23, 2019

Codecov Report

Merging #340 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #340      +/-   ##
=========================================
- Coverage   98.85%   98.8%   -0.05%     
=========================================
  Files          18      18              
  Lines        4024    4027       +3     
=========================================
+ Hits         3978    3979       +1     
- Misses         27      28       +1     
- Partials       19      20       +1
Impacted Files Coverage Δ
datavalidation.go 97.43% <100%> (-2.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c5c99e...daf32a3. Read the comment docs.

@xuri xuri merged commit 36fc39f into qax-os:master Jan 24, 2019
@xuri
Copy link
Member

xuri commented Jan 24, 2019

LGTM, thanks @rentiansheng

@rentiansheng rentiansheng deleted the datavalidation_formula_error branch January 24, 2019 01:31
@xuri xuri added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 6, 2020
nullfy pushed a commit to nullfy/excelize that referenced this pull request Oct 23, 2020
…a_error

fix: datavalidation list error, formula > 255 issue qax-os#339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datavalidation list error
3 participants