Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/dot-transfer-broadcast #1328

Merged
merged 5 commits into from
Sep 5, 2022
Merged

Bug/dot-transfer-broadcast #1328

merged 5 commits into from
Sep 5, 2022

Conversation

GaroRobe
Copy link
Contributor

Referenced issues

Fix extrinsics status in polkadot js #1324

Description of the Change

Fixed operations order in submitAndWatchExtrinsic that led to not sending "broadcast" message.

Benefits

Possible Drawbacks

Usage Examples or Tests

Alternate Designs

@GaroRobe GaroRobe requested review from Harrm and kamilsa August 24, 2022 20:19
@GaroRobe GaroRobe self-assigned this Aug 24, 2022
@GaroRobe GaroRobe added the bug Something isn't working label Aug 24, 2022
@GaroRobe GaroRobe linked an issue Aug 24, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #1328 (d058b7f) into master (408a4e9) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1328      +/-   ##
==========================================
- Coverage   25.47%   25.45%   -0.03%     
==========================================
  Files         606      606              
  Lines       21943    21945       +2     
  Branches    11385    11387       +2     
==========================================
- Hits         5591     5587       -4     
- Misses      11185    11193       +8     
+ Partials     5167     5165       -2     
Impacted Files Coverage Δ
core/api/service/author/impl/author_api_impl.cpp 34.04% <0.00%> (-0.75%) ⬇️
...re/transaction_pool/impl/transaction_pool_impl.hpp 100.00% <ø> (ø)
core/transaction_pool/transaction_pool.hpp 100.00% <ø> (ø)
core/api/transport/impl/ws/ws_listener_impl.cpp 40.27% <0.00%> (-1.39%) ⬇️
core/api/service/impl/api_service_impl.cpp 13.26% <0.00%> (-1.03%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@GaroRobe GaroRobe enabled auto-merge (squash) August 25, 2022 20:18
@GaroRobe GaroRobe merged commit ce9e0fc into master Sep 5, 2022
@GaroRobe GaroRobe deleted the bug/dot-transfer-broadcast branch September 5, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix extrinsics status in polkadot js
3 participants