Add testWai' that works better with withResource #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing my wai application, and wanted to reset it between tests to isolate them from each other.
I found the function
withResource :: IO a -> (a -> IO ()) -> (IO a -> TestTree) -> TestTreethat seemed like a good fit, but I couldn't figure out how to use it together withtestWai :: Application -> TestName -> Session () -> TestTree.To make the pieces fit, I introduced
testWai' :: IO Application -> TestName -> Session () -> TestTree.This required changing the type of
Sessto hold anIO Applicationinstead of anApplication.Hopefully, this will be accepted, and help others that want to test wai apps with Tasty.
Please let me know if I can do anything else to make this PR agreeable to you.