Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve(plugins_sync): handle cases where a downloaded plugin is not a valid ZIP #577

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

Guts
Copy link
Collaborator

@Guts Guts commented Nov 28, 2024

No description provided.

@Guts Guts requested a review from jmkerloch November 28, 2024 16:46
@Guts Guts self-assigned this Nov 28, 2024
@github-actions github-actions bot added enhancement New feature or request jobs Scenarios and jobs labels Nov 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.43%. Comparing base (01799f1) to head (97b1dbd).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...ployment_toolbelt/jobs/job_plugins_synchronizer.py 50.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
- Coverage   70.48%   70.43%   -0.06%     
==========================================
  Files          47       47              
  Lines        3158     3162       +4     
  Branches      554      554              
==========================================
+ Hits         2226     2227       +1     
- Misses        738      741       +3     
  Partials      194      194              
Flag Coverage Δ
unittests 69.86% <50.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ployment_toolbelt/jobs/job_plugins_synchronizer.py 74.24% <50.00%> (-3.18%) ⬇️

Copy link
Collaborator

@jmkerloch jmkerloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 🚀

@Guts Guts force-pushed the improve/handle-invalid-zip-corrupted-plugin branch from 8951834 to 97b1dbd Compare November 29, 2024 09:39
@Guts Guts enabled auto-merge November 29, 2024 09:39
Copy link

sonarcloud bot commented Nov 29, 2024

@Guts Guts merged commit d3e72d1 into main Nov 29, 2024
25 checks passed
@Guts Guts deleted the improve/handle-invalid-zip-corrupted-plugin branch November 29, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request jobs Scenarios and jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants