Test #6
Test #6
Conversation
|
Note that I use flexible header tests (sbatch only) for step 2 to step 7. Otherwise for each other step. e.g., add a new line will lead to the failure of the test. Let me know your thoughts. Thanks, Jianshu |
| with open(step1_path, "r") as f: | ||
| obs_lines = [ln.rstrip("\n") for ln in f.readlines()] | ||
|
|
||
| self.assertCountEqual( |
There was a problem hiding this comment.
I'm really confused about this PR; why not continue using this kind of test vs. adding all the rest of methods to compare string? Is it to minimize changes in the future or something else? FWIW, the idea of testing this is to make sure that whatever change is made in the main scripts/code, we have to change the code in the test too - as a sanity check. Additionally, for most tests you are only testing the header which, if I understand the concept, it will not test the full script, no?
|
@antgonza, please review and then merge it. Everything looks good now. |
2 participants
add more check to each slurm script.