Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Conversation

@garrison
Copy link
Member

Summary

This removes the notebook dependencies from requirements-dev.txt, as otherwise they are specified in two places. This PR supersedes #37.

Details and comments

garrison added 2 commits June 13, 2022 21:28
Otherwise, they are specified in two places.
They no longer have the same dependencies, so can no longer be shared.
@garrison garrison force-pushed the dry-notebook-dependencies branch from 61a4d0f to 5d83a5e Compare June 14, 2022 02:11
@garrison garrison marked this pull request as ready for review June 14, 2022 13:47
@garrison
Copy link
Member Author

I've experienced the following error when running tox -elint on this branch on one machine, but not on my primary workstation:

************* Module tests.test_backends
tests/test_backends.py:20:0: E0401: Unable to import 'qiskit.providers.ibmq' (import-error)
tests/test_backends.py:20:0: E0611: No name 'ibmq' in module 'qiskit.providers' (no-name-in-module)

------------------------------------------------------------------
Your code has been rated at 9.91/10 (previous run: 9.91/10, +0.00)

ERROR: InvocationError for command /tmp/prototype-qrao/.tox/lint/bin/pylint -rn --py-version=3.6 --disable=fixme,invalid-name,missing-function-docstring,protected-access,duplicate-code qrao tests (exited with code 14)
___________________________________ summary ____________________________________
ERROR:   lint: commands failed

All other tox environments work, even on the machine where this one fails.

I think I'll merge this soon anyway, as it will presumably be resolved once #15 is merged, in case it ever crops up again.

@garrison garrison merged commit 4434a1b into main Jun 16, 2022
@garrison garrison deleted the dry-notebook-dependencies branch June 16, 2022 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants