From cf53064ce6f99af717fc724903c79000ab2adbfd Mon Sep 17 00:00:00 2001 From: Tristan NEMOZ Date: Wed, 25 Sep 2024 00:08:27 +0200 Subject: [PATCH 1/3] Added pylint ignores --- .../amplitude_amplifiers/amplification_problem.py | 1 + qiskit_algorithms/amplitude_estimators/ae_utils.py | 2 +- qiskit_algorithms/amplitude_estimators/estimation_problem.py | 1 + qiskit_algorithms/amplitude_estimators/iae.py | 1 + qiskit_algorithms/gradients/spsa/spsa_estimator_gradient.py | 1 + qiskit_algorithms/gradients/spsa/spsa_sampler_gradient.py | 1 + qiskit_algorithms/minimum_eigensolvers/sampling_vqe.py | 1 + qiskit_algorithms/optimizers/adam_amsgrad.py | 1 + qiskit_algorithms/optimizers/aqgd.py | 2 ++ qiskit_algorithms/optimizers/cg.py | 2 +- qiskit_algorithms/optimizers/cobyla.py | 2 +- qiskit_algorithms/optimizers/gradient_descent.py | 1 + qiskit_algorithms/optimizers/gsls.py | 5 ++++- qiskit_algorithms/optimizers/l_bfgs_b.py | 2 +- qiskit_algorithms/optimizers/nelder_mead.py | 2 +- qiskit_algorithms/optimizers/nft.py | 4 ++-- qiskit_algorithms/optimizers/p_bfgs.py | 2 +- qiskit_algorithms/optimizers/powell.py | 2 +- qiskit_algorithms/optimizers/qnspsa.py | 2 ++ qiskit_algorithms/optimizers/slsqp.py | 2 +- qiskit_algorithms/optimizers/spsa.py | 4 ++++ qiskit_algorithms/optimizers/tnc.py | 2 +- qiskit_algorithms/phase_estimators/ipe.py | 1 + qiskit_algorithms/time_evolvers/pvqd/pvqd.py | 2 ++ qiskit_algorithms/time_evolvers/pvqd/pvqd_result.py | 1 + qiskit_algorithms/time_evolvers/time_evolution_problem.py | 1 + .../variational/solvers/ode/forward_euler_solver.py | 1 + .../variational/solvers/var_qte_linear_solver.py | 1 + qiskit_algorithms/time_evolvers/variational/var_qite.py | 1 + qiskit_algorithms/time_evolvers/variational/var_qrte.py | 1 + qiskit_algorithms/time_evolvers/variational/var_qte.py | 1 + .../time_evolvers/variational/var_qte_result.py | 1 + test/optimizers/test_spsa.py | 1 + test/test_phase_estimator.py | 3 +++ test/time_evolvers/test_trotter_qrte.py | 2 ++ test/time_evolvers/variational/test_var_qite.py | 1 + 36 files changed, 49 insertions(+), 12 deletions(-) diff --git a/qiskit_algorithms/amplitude_amplifiers/amplification_problem.py b/qiskit_algorithms/amplitude_amplifiers/amplification_problem.py index dec39bbb..709e727d 100644 --- a/qiskit_algorithms/amplitude_amplifiers/amplification_problem.py +++ b/qiskit_algorithms/amplitude_amplifiers/amplification_problem.py @@ -29,6 +29,7 @@ class AmplificationProblem: on the optimal bitstring. """ + # pylint: disable=too-many-positional-arguments def __init__( self, oracle: QuantumCircuit | Statevector, diff --git a/qiskit_algorithms/amplitude_estimators/ae_utils.py b/qiskit_algorithms/amplitude_estimators/ae_utils.py index 6a601f43..5553a999 100644 --- a/qiskit_algorithms/amplitude_estimators/ae_utils.py +++ b/qiskit_algorithms/amplitude_estimators/ae_utils.py @@ -19,7 +19,7 @@ # pylint: disable=invalid-name - +# pylint: disable=too-many-positional-arguments def bisect_max(f, a, b, steps=50, minwidth=1e-12, retval=False): """Find the maximum of the real-valued function f in the interval [a, b] using bisection. diff --git a/qiskit_algorithms/amplitude_estimators/estimation_problem.py b/qiskit_algorithms/amplitude_estimators/estimation_problem.py index 39ac0a2d..282ca4cd 100644 --- a/qiskit_algorithms/amplitude_estimators/estimation_problem.py +++ b/qiskit_algorithms/amplitude_estimators/estimation_problem.py @@ -31,6 +31,7 @@ class EstimationProblem: or a custom Grover operator. """ + # pylint: disable=too-many-positional-arguments def __init__( self, state_preparation: QuantumCircuit, diff --git a/qiskit_algorithms/amplitude_estimators/iae.py b/qiskit_algorithms/amplitude_estimators/iae.py index 7e06f983..67a36d9f 100644 --- a/qiskit_algorithms/amplitude_estimators/iae.py +++ b/qiskit_algorithms/amplitude_estimators/iae.py @@ -47,6 +47,7 @@ class IterativeAmplitudeEstimation(AmplitudeEstimator): `arXiv:quant-ph/0005055 `_. """ + # pylint: disable=too-many-positional-arguments def __init__( self, epsilon_target: float, diff --git a/qiskit_algorithms/gradients/spsa/spsa_estimator_gradient.py b/qiskit_algorithms/gradients/spsa/spsa_estimator_gradient.py index 9ace83af..e7e7fd95 100644 --- a/qiskit_algorithms/gradients/spsa/spsa_estimator_gradient.py +++ b/qiskit_algorithms/gradients/spsa/spsa_estimator_gradient.py @@ -40,6 +40,7 @@ class SPSAEstimatorGradient(BaseEstimatorGradient): `doi: 10.1109/TAC.2000.880982 `_ """ + # pylint: disable=too-many-positional-arguments def __init__( self, estimator: BaseEstimator, diff --git a/qiskit_algorithms/gradients/spsa/spsa_sampler_gradient.py b/qiskit_algorithms/gradients/spsa/spsa_sampler_gradient.py index 8a83a64a..57a93357 100644 --- a/qiskit_algorithms/gradients/spsa/spsa_sampler_gradient.py +++ b/qiskit_algorithms/gradients/spsa/spsa_sampler_gradient.py @@ -40,6 +40,7 @@ class SPSASamplerGradient(BaseSamplerGradient): `doi: 10.1109/TAC.2000.880982 `_. """ + # pylint: disable=too-many-positional-arguments def __init__( self, sampler: BaseSampler, diff --git a/qiskit_algorithms/minimum_eigensolvers/sampling_vqe.py b/qiskit_algorithms/minimum_eigensolvers/sampling_vqe.py index 3d007452..0ebd7e05 100644 --- a/qiskit_algorithms/minimum_eigensolvers/sampling_vqe.py +++ b/qiskit_algorithms/minimum_eigensolvers/sampling_vqe.py @@ -335,6 +335,7 @@ def evaluate_energy(parameters: np.ndarray) -> np.ndarray | float: return evaluate_energy + # pylint: disable=too-many-positional-arguments def _build_sampling_vqe_result( self, ansatz: QuantumCircuit, diff --git a/qiskit_algorithms/optimizers/adam_amsgrad.py b/qiskit_algorithms/optimizers/adam_amsgrad.py index 624f8214..26da4840 100644 --- a/qiskit_algorithms/optimizers/adam_amsgrad.py +++ b/qiskit_algorithms/optimizers/adam_amsgrad.py @@ -57,6 +57,7 @@ class ADAM(Optimizer): "snapshot_dir", ] + # pylint: disable=too-many-positional-arguments def __init__( self, maxiter: int = 10000, diff --git a/qiskit_algorithms/optimizers/aqgd.py b/qiskit_algorithms/optimizers/aqgd.py index f821fd5d..05619451 100644 --- a/qiskit_algorithms/optimizers/aqgd.py +++ b/qiskit_algorithms/optimizers/aqgd.py @@ -49,6 +49,7 @@ class AQGD(Optimizer): _OPTIONS = ["maxiter", "eta", "tol", "disp", "momentum", "param_tol", "averaging"] + # pylint: disable=too-many-positional-arguments def __init__( self, maxiter: int | list[int] = 1000, @@ -179,6 +180,7 @@ def _compute_objective_fn_and_gradient( gradient = 0.5 * (values[1 : num_params + 1] - values[1 + num_params :]) return obj_value, gradient + # pylint: disable=too-many-positional-arguments def _update( self, params: np.ndarray, diff --git a/qiskit_algorithms/optimizers/cg.py b/qiskit_algorithms/optimizers/cg.py index e6976166..f85160b6 100644 --- a/qiskit_algorithms/optimizers/cg.py +++ b/qiskit_algorithms/optimizers/cg.py @@ -33,7 +33,7 @@ class CG(SciPyOptimizer): _OPTIONS = ["maxiter", "disp", "gtol", "eps"] - # pylint: disable=unused-argument + # pylint: disable=unused-argument, too-many-positional-arguments def __init__( self, maxiter: int = 20, diff --git a/qiskit_algorithms/optimizers/cobyla.py b/qiskit_algorithms/optimizers/cobyla.py index f5eaa040..f4baedf0 100644 --- a/qiskit_algorithms/optimizers/cobyla.py +++ b/qiskit_algorithms/optimizers/cobyla.py @@ -31,7 +31,7 @@ class COBYLA(SciPyOptimizer): _OPTIONS = ["maxiter", "disp", "rhobeg"] - # pylint: disable=unused-argument + # pylint: disable=unused-argument, too-many-positional-arguments def __init__( self, maxiter: int = 1000, diff --git a/qiskit_algorithms/optimizers/gradient_descent.py b/qiskit_algorithms/optimizers/gradient_descent.py index 6051c379..2cad7e41 100644 --- a/qiskit_algorithms/optimizers/gradient_descent.py +++ b/qiskit_algorithms/optimizers/gradient_descent.py @@ -174,6 +174,7 @@ def grad(x): """ + # pylint: disable=too-many-positional-arguments def __init__( self, maxiter: int = 100, diff --git a/qiskit_algorithms/optimizers/gsls.py b/qiskit_algorithms/optimizers/gsls.py index c6b423db..9f7c58f9 100644 --- a/qiskit_algorithms/optimizers/gsls.py +++ b/qiskit_algorithms/optimizers/gsls.py @@ -51,7 +51,7 @@ class GSLS(Optimizer): "max_failed_rejection_sampling", ] - # pylint: disable=unused-argument + # pylint: disable=unused-argument, too-many-positional-arguments def __init__( self, maxiter: int = 10000, @@ -131,6 +131,7 @@ def minimize( return result + # pylint: disable=too-many-positional-arguments def ls_optimize( self, n: int, @@ -270,6 +271,7 @@ def sample_points( return points, directions + # pylint: disable=too-many-positional-arguments def sample_set( self, n: int, x: np.ndarray, var_lb: np.ndarray, var_ub: np.ndarray, num_points: int ) -> tuple[np.ndarray, np.ndarray]: @@ -342,6 +344,7 @@ def sample_set( x + self._options["sampling_radius"] * accepted[:num_points], ) + # pylint: disable=too-many-positional-arguments def gradient_approximation( self, n: int, diff --git a/qiskit_algorithms/optimizers/l_bfgs_b.py b/qiskit_algorithms/optimizers/l_bfgs_b.py index 1c529e0a..29cc4666 100644 --- a/qiskit_algorithms/optimizers/l_bfgs_b.py +++ b/qiskit_algorithms/optimizers/l_bfgs_b.py @@ -46,7 +46,7 @@ class L_BFGS_B(SciPyOptimizer): # pylint: disable=invalid-name _OPTIONS = ["maxfun", "maxiter", "ftol", "iprint", "eps"] - # pylint: disable=unused-argument + # pylint: disable=unused-argument, too-many-positional-arguments def __init__( self, maxfun: int = 15000, diff --git a/qiskit_algorithms/optimizers/nelder_mead.py b/qiskit_algorithms/optimizers/nelder_mead.py index a8c3a264..645feeef 100644 --- a/qiskit_algorithms/optimizers/nelder_mead.py +++ b/qiskit_algorithms/optimizers/nelder_mead.py @@ -40,7 +40,7 @@ class NELDER_MEAD(SciPyOptimizer): # pylint: disable=invalid-name _OPTIONS = ["maxiter", "maxfev", "disp", "xatol", "adaptive"] - # pylint: disable=unused-argument + # pylint: disable=unused-argument, too-many-positional-arguments def __init__( self, maxiter: int | None = None, diff --git a/qiskit_algorithms/optimizers/nft.py b/qiskit_algorithms/optimizers/nft.py index 504e5f73..b08cd494 100644 --- a/qiskit_algorithms/optimizers/nft.py +++ b/qiskit_algorithms/optimizers/nft.py @@ -29,7 +29,7 @@ class NFT(SciPyOptimizer): _OPTIONS = ["maxiter", "maxfev", "disp", "reset_interval"] - # pylint: disable=unused-argument + # pylint: disable=unused-argument, too-many-positional-arguments def __init__( self, maxiter: int | None = None, @@ -69,7 +69,7 @@ def __init__( super().__init__(method=nakanishi_fujii_todo, options=options, **kwargs) -# pylint: disable=invalid-name +# pylint: disable=invalid-name, too-many-positional-arguments def nakanishi_fujii_todo( fun, x0, args=(), maxiter=None, maxfev=1024, reset_interval=32, eps=1e-32, callback=None, **_ ): diff --git a/qiskit_algorithms/optimizers/p_bfgs.py b/qiskit_algorithms/optimizers/p_bfgs.py index e1a98bd0..9238ccf9 100644 --- a/qiskit_algorithms/optimizers/p_bfgs.py +++ b/qiskit_algorithms/optimizers/p_bfgs.py @@ -52,7 +52,7 @@ class P_BFGS(SciPyOptimizer): # pylint: disable=invalid-name _OPTIONS = ["maxfun", "ftol", "iprint"] - # pylint: disable=unused-argument + # pylint: disable=unused-argument, too-many-positional-arguments def __init__( self, maxfun: int = 1000, diff --git a/qiskit_algorithms/optimizers/powell.py b/qiskit_algorithms/optimizers/powell.py index 1b53131d..570d18d3 100644 --- a/qiskit_algorithms/optimizers/powell.py +++ b/qiskit_algorithms/optimizers/powell.py @@ -33,7 +33,7 @@ class POWELL(SciPyOptimizer): _OPTIONS = ["maxiter", "maxfev", "disp", "xtol"] - # pylint: disable=unused-argument + # pylint: disable=unused-argument, too-many-positional-arguments def __init__( self, maxiter: int | None = None, diff --git a/qiskit_algorithms/optimizers/qnspsa.py b/qiskit_algorithms/optimizers/qnspsa.py index cc9c0d63..d29793b7 100644 --- a/qiskit_algorithms/optimizers/qnspsa.py +++ b/qiskit_algorithms/optimizers/qnspsa.py @@ -93,6 +93,7 @@ def loss(x): """ + # pylint: disable=too-many-positional-arguments def __init__( self, fidelity: FIDELITY, @@ -184,6 +185,7 @@ def __init__( self.fidelity = fidelity + # pylint: disable=too-many-positional-arguments def _point_sample(self, loss, x, eps, delta1, delta2): loss_points = [x + eps * delta1, x - eps * delta1] fidelity_points = [ diff --git a/qiskit_algorithms/optimizers/slsqp.py b/qiskit_algorithms/optimizers/slsqp.py index 20eb49ef..7a9714b4 100644 --- a/qiskit_algorithms/optimizers/slsqp.py +++ b/qiskit_algorithms/optimizers/slsqp.py @@ -36,7 +36,7 @@ class SLSQP(SciPyOptimizer): _OPTIONS = ["maxiter", "disp", "ftol", "eps"] - # pylint: disable=unused-argument + # pylint: disable=unused-argument, too-many-positional-arguments def __init__( self, maxiter: int = 100, diff --git a/qiskit_algorithms/optimizers/spsa.py b/qiskit_algorithms/optimizers/spsa.py index 62b124d4..1a13fb97 100644 --- a/qiskit_algorithms/optimizers/spsa.py +++ b/qiskit_algorithms/optimizers/spsa.py @@ -161,6 +161,7 @@ def __call__(self, nfev, parameters, value, stepsize, accepted) -> bool: """ + # pylint: disable=too-many-positional-arguments def __init__( self, maxiter: int = 100, @@ -280,6 +281,7 @@ def __init__( self._nfev: int | None = None # the number of function evaluations self._smoothed_hessian: np.ndarray | None = None # smoothed average of the Hessians + # pylint: disable=too-many-positional-arguments @staticmethod def calibrate( loss: Callable[[np.ndarray], float], @@ -413,6 +415,7 @@ def settings(self) -> dict[str, Any]: "termination_checker": self.termination_checker, } + # pylint: disable=too-many-positional-arguments def _point_sample(self, loss, x, eps, delta1, delta2): """A single sample of the gradient at position ``x`` in direction ``delta``.""" # points to evaluate @@ -478,6 +481,7 @@ def _point_estimate(self, loss, x, eps, num_samples): hessian_estimate / num_samples, ) + # pylint: disable=too-many-positional-arguments def _compute_update(self, loss, x, k, eps, lse_solver): # compute the perturbations if isinstance(self.resamplings, dict): diff --git a/qiskit_algorithms/optimizers/tnc.py b/qiskit_algorithms/optimizers/tnc.py index 1d9665b5..369a9142 100644 --- a/qiskit_algorithms/optimizers/tnc.py +++ b/qiskit_algorithms/optimizers/tnc.py @@ -33,7 +33,7 @@ class TNC(SciPyOptimizer): _OPTIONS = ["maxiter", "disp", "accuracy", "ftol", "xtol", "gtol", "eps"] - # pylint: disable=unused-argument + # pylint: disable=unused-argument, too-many-positional-arguments def __init__( self, maxiter: int = 100, diff --git a/qiskit_algorithms/phase_estimators/ipe.py b/qiskit_algorithms/phase_estimators/ipe.py index 7c797182..2b16ec4f 100644 --- a/qiskit_algorithms/phase_estimators/ipe.py +++ b/qiskit_algorithms/phase_estimators/ipe.py @@ -59,6 +59,7 @@ def __init__( self._num_iterations = num_iterations self._sampler = sampler + # pylint: disable=too-many-positional-arguments def construct_circuit( self, unitary: QuantumCircuit, diff --git a/qiskit_algorithms/time_evolvers/pvqd/pvqd.py b/qiskit_algorithms/time_evolvers/pvqd/pvqd.py index 03c7f3ab..73e6e4eb 100644 --- a/qiskit_algorithms/time_evolvers/pvqd/pvqd.py +++ b/qiskit_algorithms/time_evolvers/pvqd/pvqd.py @@ -115,6 +115,7 @@ class PVQD(RealTimeEvolver): `Quantum 5, 512 `_. """ + # pylint: disable=too-many-positional-arguments def __init__( self, fidelity: BaseStateFidelity, @@ -167,6 +168,7 @@ def __init__( self.evolution = evolution self.use_parameter_shift = use_parameter_shift + # pylint: disable=too-many-positional-arguments def step( self, hamiltonian: BaseOperator, diff --git a/qiskit_algorithms/time_evolvers/pvqd/pvqd_result.py b/qiskit_algorithms/time_evolvers/pvqd/pvqd_result.py index 194aefcb..90704a9f 100644 --- a/qiskit_algorithms/time_evolvers/pvqd/pvqd_result.py +++ b/qiskit_algorithms/time_evolvers/pvqd/pvqd_result.py @@ -23,6 +23,7 @@ class PVQDResult(TimeEvolutionResult): """The result object for the p-VQD algorithm.""" + # pylint: disable=too-many-positional-arguments def __init__( self, evolved_state: QuantumCircuit, diff --git a/qiskit_algorithms/time_evolvers/time_evolution_problem.py b/qiskit_algorithms/time_evolvers/time_evolution_problem.py index 558b3d3d..eabcd7bc 100644 --- a/qiskit_algorithms/time_evolvers/time_evolution_problem.py +++ b/qiskit_algorithms/time_evolvers/time_evolution_problem.py @@ -46,6 +46,7 @@ class TimeEvolutionProblem: state. """ + # pylint: disable=too-many-positional-arguments def __init__( self, hamiltonian: BaseOperator, diff --git a/qiskit_algorithms/time_evolvers/variational/solvers/ode/forward_euler_solver.py b/qiskit_algorithms/time_evolvers/variational/solvers/ode/forward_euler_solver.py index 1edde617..3528ad03 100644 --- a/qiskit_algorithms/time_evolvers/variational/solvers/ode/forward_euler_solver.py +++ b/qiskit_algorithms/time_evolvers/variational/solvers/ode/forward_euler_solver.py @@ -20,6 +20,7 @@ class ForwardEulerSolver(OdeSolver): """Forward Euler ODE solver.""" + # pylint: disable=too-many-positional-arguments def __init__( self, function: Callable, diff --git a/qiskit_algorithms/time_evolvers/variational/solvers/var_qte_linear_solver.py b/qiskit_algorithms/time_evolvers/variational/solvers/var_qte_linear_solver.py index 00d3a693..65366150 100644 --- a/qiskit_algorithms/time_evolvers/variational/solvers/var_qte_linear_solver.py +++ b/qiskit_algorithms/time_evolvers/variational/solvers/var_qte_linear_solver.py @@ -28,6 +28,7 @@ class VarQTELinearSolver: """Class for solving linear equations for Quantum Time Evolution.""" + # pylint: disable=too-many-positional-arguments def __init__( self, var_principle: VariationalPrinciple, diff --git a/qiskit_algorithms/time_evolvers/variational/var_qite.py b/qiskit_algorithms/time_evolvers/variational/var_qite.py index c44219ce..4c42019f 100644 --- a/qiskit_algorithms/time_evolvers/variational/var_qite.py +++ b/qiskit_algorithms/time_evolvers/variational/var_qite.py @@ -72,6 +72,7 @@ class VarQITE(VarQTE, ImaginaryTimeEvolver): evolution_result = var_qite.evolve(evolution_problem) """ + # pylint: disable=too-many-positional-arguments def __init__( self, ansatz: QuantumCircuit, diff --git a/qiskit_algorithms/time_evolvers/variational/var_qrte.py b/qiskit_algorithms/time_evolvers/variational/var_qrte.py index 21f8cce0..6520d630 100644 --- a/qiskit_algorithms/time_evolvers/variational/var_qrte.py +++ b/qiskit_algorithms/time_evolvers/variational/var_qrte.py @@ -73,6 +73,7 @@ class VarQRTE(VarQTE, RealTimeEvolver): evolution_result = var_qrte.evolve(evolution_problem) """ + # pylint: disable=too-many-positional-arguments def __init__( self, ansatz: QuantumCircuit, diff --git a/qiskit_algorithms/time_evolvers/variational/var_qte.py b/qiskit_algorithms/time_evolvers/variational/var_qte.py index 42e50b8b..dc5a5af5 100644 --- a/qiskit_algorithms/time_evolvers/variational/var_qte.py +++ b/qiskit_algorithms/time_evolvers/variational/var_qte.py @@ -71,6 +71,7 @@ class VarQTE(ABC): Theory of variational quantum simulation. ``_ """ + # pylint: disable=too-many-positional-arguments def __init__( self, ansatz: QuantumCircuit, diff --git a/qiskit_algorithms/time_evolvers/variational/var_qte_result.py b/qiskit_algorithms/time_evolvers/variational/var_qte_result.py index c3cb2f79..5918f91f 100644 --- a/qiskit_algorithms/time_evolvers/variational/var_qte_result.py +++ b/qiskit_algorithms/time_evolvers/variational/var_qte_result.py @@ -30,6 +30,7 @@ class VarQTEResult(TimeEvolutionResult): each evolution step. """ + # pylint: disable=too-many-positional-arguments def __init__( self, evolved_state: QuantumCircuit, diff --git a/test/optimizers/test_spsa.py b/test/optimizers/test_spsa.py index c5622eff..81423d3f 100644 --- a/test/optimizers/test_spsa.py +++ b/test/optimizers/test_spsa.py @@ -146,6 +146,7 @@ class TerminationChecker: def __init__(self): self.values = [] + # pylint: disable=too-many-positional-arguments def __call__(self, nfev, point, fvalue, stepsize, accepted) -> bool: self.values.append(fvalue) diff --git a/test/test_phase_estimator.py b/test/test_phase_estimator.py index 1b7ca114..ded813a1 100644 --- a/test/test_phase_estimator.py +++ b/test/test_phase_estimator.py @@ -34,6 +34,7 @@ class TestHamiltonianPhaseEstimation(QiskitAlgorithmsTestCase): """Tests for obtaining eigenvalues from phase estimation""" + # pylint: disable=too-many-positional-arguments # sampler tests def hamiltonian_pe_sampler( self, @@ -150,6 +151,7 @@ def test_matrix_evolution_sampler(self): class TestPhaseEstimation(QiskitAlgorithmsTestCase): """Evolution tests.""" + # pylint: disable=too-many-positional-arguments # sampler tests def one_phase_sampler( self, @@ -284,6 +286,7 @@ def test_phase_estimation_scale_from_operator(self): scale = PhaseEstimationScale.from_pauli_sum(op) self.assertEqual(scale._bound, 4.0) + # pylint: disable=too-many-positional-arguments def phase_estimation_sampler( self, unitary_circuit, diff --git a/test/time_evolvers/test_trotter_qrte.py b/test/time_evolvers/test_trotter_qrte.py index bd7ca48c..3dda5710 100644 --- a/test/time_evolvers/test_trotter_qrte.py +++ b/test/time_evolvers/test_trotter_qrte.py @@ -239,6 +239,7 @@ def test_barriers(self, insert_barrier): expected_circuit.decompose(reps=3), evolution_result.evolved_state.decompose(reps=5) ) + # pylint: disable=too-many-positional-arguments @staticmethod def _run_error_test(initial_state, operator, aux_ops, estimator, t_param, param_value_dict): time = 1 @@ -255,6 +256,7 @@ def _run_error_test(initial_state, operator, aux_ops, estimator, t_param, param_ ) _ = trotter_qrte.evolve(evolution_problem) + # pylint: disable=too-many-positional-arguments @staticmethod def _get_expected_trotter_qrte(operator, time, num_timesteps, init_state, observables, t_param): """Compute reference values for Trotter evolution via exact matrix exponentiation.""" diff --git a/test/time_evolvers/variational/test_var_qite.py b/test/time_evolvers/variational/test_var_qite.py index e25b3743..18fbdcbd 100644 --- a/test/time_evolvers/variational/test_var_qite.py +++ b/test/time_evolvers/variational/test_var_qite.py @@ -309,6 +309,7 @@ def test_run_d_1_time_dependent(self): float(parameter_value), thetas_expected_shots[i], decimal=2 ) + # pylint: disable=too-many-positional-arguments def _test_helper(self, observable, thetas_expected, time, var_qite, decimal): evolution_problem = TimeEvolutionProblem(observable, time) evolution_result = var_qite.evolve(evolution_problem) From 938bda405dffd8275a2b764f90b8e18573a6fbac Mon Sep 17 00:00:00 2001 From: Tristan NEMOZ Date: Wed, 25 Sep 2024 00:23:29 +0200 Subject: [PATCH 2/3] Fixed black --- qiskit_algorithms/amplitude_estimators/ae_utils.py | 1 + 1 file changed, 1 insertion(+) diff --git a/qiskit_algorithms/amplitude_estimators/ae_utils.py b/qiskit_algorithms/amplitude_estimators/ae_utils.py index 5553a999..b3d0120d 100644 --- a/qiskit_algorithms/amplitude_estimators/ae_utils.py +++ b/qiskit_algorithms/amplitude_estimators/ae_utils.py @@ -19,6 +19,7 @@ # pylint: disable=invalid-name + # pylint: disable=too-many-positional-arguments def bisect_max(f, a, b, steps=50, minwidth=1e-12, retval=False): """Find the maximum of the real-valued function f in the interval [a, b] using bisection. From f6492f96239064fc1fb679b5a2ff80aaf62639b1 Mon Sep 17 00:00:00 2001 From: Tristan NEMOZ <36485441+tnemoz@users.noreply.github.com> Date: Wed, 25 Sep 2024 13:41:50 +0200 Subject: [PATCH 3/3] Update copyright notices --- qiskit_algorithms/amplitude_amplifiers/amplification_problem.py | 2 +- qiskit_algorithms/amplitude_estimators/iae.py | 2 +- qiskit_algorithms/gradients/spsa/spsa_estimator_gradient.py | 2 +- qiskit_algorithms/gradients/spsa/spsa_sampler_gradient.py | 2 +- qiskit_algorithms/optimizers/cg.py | 2 +- qiskit_algorithms/optimizers/cobyla.py | 2 +- qiskit_algorithms/optimizers/gsls.py | 2 +- qiskit_algorithms/optimizers/l_bfgs_b.py | 2 +- qiskit_algorithms/optimizers/nelder_mead.py | 2 +- qiskit_algorithms/optimizers/nft.py | 2 +- qiskit_algorithms/optimizers/p_bfgs.py | 2 +- qiskit_algorithms/optimizers/powell.py | 2 +- qiskit_algorithms/optimizers/qnspsa.py | 2 +- qiskit_algorithms/optimizers/slsqp.py | 2 +- qiskit_algorithms/optimizers/tnc.py | 2 +- qiskit_algorithms/phase_estimators/ipe.py | 2 +- qiskit_algorithms/time_evolvers/pvqd/pvqd.py | 2 +- qiskit_algorithms/time_evolvers/pvqd/pvqd_result.py | 2 +- qiskit_algorithms/time_evolvers/time_evolution_problem.py | 2 +- .../variational/solvers/ode/forward_euler_solver.py | 2 +- .../time_evolvers/variational/solvers/var_qte_linear_solver.py | 2 +- qiskit_algorithms/time_evolvers/variational/var_qite.py | 2 +- qiskit_algorithms/time_evolvers/variational/var_qrte.py | 2 +- qiskit_algorithms/time_evolvers/variational/var_qte.py | 2 +- qiskit_algorithms/time_evolvers/variational/var_qte_result.py | 2 +- test/optimizers/test_spsa.py | 2 +- test/test_phase_estimator.py | 2 +- test/time_evolvers/variational/test_var_qite.py | 2 +- 28 files changed, 28 insertions(+), 28 deletions(-) diff --git a/qiskit_algorithms/amplitude_amplifiers/amplification_problem.py b/qiskit_algorithms/amplitude_amplifiers/amplification_problem.py index 709e727d..c528c466 100644 --- a/qiskit_algorithms/amplitude_amplifiers/amplification_problem.py +++ b/qiskit_algorithms/amplitude_amplifiers/amplification_problem.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2021, 2023. +# (C) Copyright IBM 2021, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/qiskit_algorithms/amplitude_estimators/iae.py b/qiskit_algorithms/amplitude_estimators/iae.py index 67a36d9f..2121103d 100644 --- a/qiskit_algorithms/amplitude_estimators/iae.py +++ b/qiskit_algorithms/amplitude_estimators/iae.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2018, 2023. +# (C) Copyright IBM 2018, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/qiskit_algorithms/gradients/spsa/spsa_estimator_gradient.py b/qiskit_algorithms/gradients/spsa/spsa_estimator_gradient.py index e7e7fd95..c0387a20 100644 --- a/qiskit_algorithms/gradients/spsa/spsa_estimator_gradient.py +++ b/qiskit_algorithms/gradients/spsa/spsa_estimator_gradient.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2022, 2023. +# (C) Copyright IBM 2022, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/qiskit_algorithms/gradients/spsa/spsa_sampler_gradient.py b/qiskit_algorithms/gradients/spsa/spsa_sampler_gradient.py index 57a93357..1c25b8aa 100644 --- a/qiskit_algorithms/gradients/spsa/spsa_sampler_gradient.py +++ b/qiskit_algorithms/gradients/spsa/spsa_sampler_gradient.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2022, 2023. +# (C) Copyright IBM 2022, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/qiskit_algorithms/optimizers/cg.py b/qiskit_algorithms/optimizers/cg.py index f85160b6..cbb43505 100644 --- a/qiskit_algorithms/optimizers/cg.py +++ b/qiskit_algorithms/optimizers/cg.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2018, 2023. +# (C) Copyright IBM 2018, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/qiskit_algorithms/optimizers/cobyla.py b/qiskit_algorithms/optimizers/cobyla.py index f4baedf0..f6398e51 100644 --- a/qiskit_algorithms/optimizers/cobyla.py +++ b/qiskit_algorithms/optimizers/cobyla.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2018, 2023. +# (C) Copyright IBM 2018, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/qiskit_algorithms/optimizers/gsls.py b/qiskit_algorithms/optimizers/gsls.py index 9f7c58f9..37dde8ce 100644 --- a/qiskit_algorithms/optimizers/gsls.py +++ b/qiskit_algorithms/optimizers/gsls.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2018, 2023. +# (C) Copyright IBM 2018, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/qiskit_algorithms/optimizers/l_bfgs_b.py b/qiskit_algorithms/optimizers/l_bfgs_b.py index 29cc4666..b4e08c9b 100644 --- a/qiskit_algorithms/optimizers/l_bfgs_b.py +++ b/qiskit_algorithms/optimizers/l_bfgs_b.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2018, 2023. +# (C) Copyright IBM 2018, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/qiskit_algorithms/optimizers/nelder_mead.py b/qiskit_algorithms/optimizers/nelder_mead.py index 645feeef..8cbce4e2 100644 --- a/qiskit_algorithms/optimizers/nelder_mead.py +++ b/qiskit_algorithms/optimizers/nelder_mead.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2018, 2023. +# (C) Copyright IBM 2018, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/qiskit_algorithms/optimizers/nft.py b/qiskit_algorithms/optimizers/nft.py index b08cd494..848757c1 100644 --- a/qiskit_algorithms/optimizers/nft.py +++ b/qiskit_algorithms/optimizers/nft.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2019, 2023. +# (C) Copyright IBM 2019, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/qiskit_algorithms/optimizers/p_bfgs.py b/qiskit_algorithms/optimizers/p_bfgs.py index 9238ccf9..f9056925 100644 --- a/qiskit_algorithms/optimizers/p_bfgs.py +++ b/qiskit_algorithms/optimizers/p_bfgs.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2018, 2023. +# (C) Copyright IBM 2018, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/qiskit_algorithms/optimizers/powell.py b/qiskit_algorithms/optimizers/powell.py index 570d18d3..f3feaffc 100644 --- a/qiskit_algorithms/optimizers/powell.py +++ b/qiskit_algorithms/optimizers/powell.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2018, 2023. +# (C) Copyright IBM 2018, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/qiskit_algorithms/optimizers/qnspsa.py b/qiskit_algorithms/optimizers/qnspsa.py index d29793b7..4c00741d 100644 --- a/qiskit_algorithms/optimizers/qnspsa.py +++ b/qiskit_algorithms/optimizers/qnspsa.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2021, 2023. +# (C) Copyright IBM 2021, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/qiskit_algorithms/optimizers/slsqp.py b/qiskit_algorithms/optimizers/slsqp.py index 7a9714b4..114c7bf5 100644 --- a/qiskit_algorithms/optimizers/slsqp.py +++ b/qiskit_algorithms/optimizers/slsqp.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2018, 2023. +# (C) Copyright IBM 2018, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/qiskit_algorithms/optimizers/tnc.py b/qiskit_algorithms/optimizers/tnc.py index 369a9142..b9a9012a 100644 --- a/qiskit_algorithms/optimizers/tnc.py +++ b/qiskit_algorithms/optimizers/tnc.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2018, 2023. +# (C) Copyright IBM 2018, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/qiskit_algorithms/phase_estimators/ipe.py b/qiskit_algorithms/phase_estimators/ipe.py index 2b16ec4f..bac41756 100644 --- a/qiskit_algorithms/phase_estimators/ipe.py +++ b/qiskit_algorithms/phase_estimators/ipe.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2021, 2023. +# (C) Copyright IBM 2021, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/qiskit_algorithms/time_evolvers/pvqd/pvqd.py b/qiskit_algorithms/time_evolvers/pvqd/pvqd.py index 73e6e4eb..c04d0bc3 100644 --- a/qiskit_algorithms/time_evolvers/pvqd/pvqd.py +++ b/qiskit_algorithms/time_evolvers/pvqd/pvqd.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2019, 2023. +# (C) Copyright IBM 2019, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/qiskit_algorithms/time_evolvers/pvqd/pvqd_result.py b/qiskit_algorithms/time_evolvers/pvqd/pvqd_result.py index 90704a9f..859a33bf 100644 --- a/qiskit_algorithms/time_evolvers/pvqd/pvqd_result.py +++ b/qiskit_algorithms/time_evolvers/pvqd/pvqd_result.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2022, 2023. +# (C) Copyright IBM 2022, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/qiskit_algorithms/time_evolvers/time_evolution_problem.py b/qiskit_algorithms/time_evolvers/time_evolution_problem.py index eabcd7bc..7688070f 100644 --- a/qiskit_algorithms/time_evolvers/time_evolution_problem.py +++ b/qiskit_algorithms/time_evolvers/time_evolution_problem.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2022, 2023. +# (C) Copyright IBM 2022, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/qiskit_algorithms/time_evolvers/variational/solvers/ode/forward_euler_solver.py b/qiskit_algorithms/time_evolvers/variational/solvers/ode/forward_euler_solver.py index 3528ad03..4dc2f922 100644 --- a/qiskit_algorithms/time_evolvers/variational/solvers/ode/forward_euler_solver.py +++ b/qiskit_algorithms/time_evolvers/variational/solvers/ode/forward_euler_solver.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2023. +# (C) Copyright IBM 2023, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/qiskit_algorithms/time_evolvers/variational/solvers/var_qte_linear_solver.py b/qiskit_algorithms/time_evolvers/variational/solvers/var_qte_linear_solver.py index 65366150..82de21d6 100644 --- a/qiskit_algorithms/time_evolvers/variational/solvers/var_qte_linear_solver.py +++ b/qiskit_algorithms/time_evolvers/variational/solvers/var_qte_linear_solver.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2023. +# (C) Copyright IBM 2023, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/qiskit_algorithms/time_evolvers/variational/var_qite.py b/qiskit_algorithms/time_evolvers/variational/var_qite.py index 4c42019f..a6f9d388 100644 --- a/qiskit_algorithms/time_evolvers/variational/var_qite.py +++ b/qiskit_algorithms/time_evolvers/variational/var_qite.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2023. +# (C) Copyright IBM 2023, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/qiskit_algorithms/time_evolvers/variational/var_qrte.py b/qiskit_algorithms/time_evolvers/variational/var_qrte.py index 6520d630..12cda9a2 100644 --- a/qiskit_algorithms/time_evolvers/variational/var_qrte.py +++ b/qiskit_algorithms/time_evolvers/variational/var_qrte.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2023. +# (C) Copyright IBM 2023, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/qiskit_algorithms/time_evolvers/variational/var_qte.py b/qiskit_algorithms/time_evolvers/variational/var_qte.py index dc5a5af5..bc1b2e36 100644 --- a/qiskit_algorithms/time_evolvers/variational/var_qte.py +++ b/qiskit_algorithms/time_evolvers/variational/var_qte.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2023. +# (C) Copyright IBM 2023, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/qiskit_algorithms/time_evolvers/variational/var_qte_result.py b/qiskit_algorithms/time_evolvers/variational/var_qte_result.py index 5918f91f..d6cb8992 100644 --- a/qiskit_algorithms/time_evolvers/variational/var_qte_result.py +++ b/qiskit_algorithms/time_evolvers/variational/var_qte_result.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2023. +# (C) Copyright IBM 2023, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/test/optimizers/test_spsa.py b/test/optimizers/test_spsa.py index 81423d3f..dca054e4 100644 --- a/test/optimizers/test_spsa.py +++ b/test/optimizers/test_spsa.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2021, 2023. +# (C) Copyright IBM 2021, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/test/test_phase_estimator.py b/test/test_phase_estimator.py index ded813a1..d2edad1a 100644 --- a/test/test_phase_estimator.py +++ b/test/test_phase_estimator.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2018, 2023. +# (C) Copyright IBM 2018, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory diff --git a/test/time_evolvers/variational/test_var_qite.py b/test/time_evolvers/variational/test_var_qite.py index 18fbdcbd..8ec64f54 100644 --- a/test/time_evolvers/variational/test_var_qite.py +++ b/test/time_evolvers/variational/test_var_qite.py @@ -1,6 +1,6 @@ # This code is part of a Qiskit project. # -# (C) Copyright IBM 2023. +# (C) Copyright IBM 2023, 2024. # # This code is licensed under the Apache License, Version 2.0. You may # obtain a copy of this license in the LICENSE.txt file in the root directory