Keep track of last matrix activity #10730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzarc
force-pushed
the
earlier-slave-matrix-retrieval
branch
from
970e75f
to
78faf47
Compare
drashna
approved these changes
Oct 23, 2020
tzarc
force-pushed
the
earlier-slave-matrix-retrieval
branch
from
b75a688
to
7feebb3
Compare
mtei
reviewed
Oct 25, 2020
mtei
reviewed
Nov 6, 2020
tzarc
force-pushed
the
earlier-slave-matrix-retrieval
branch
2 times, most recently
from
6c8c734
to
0860c29
Compare
tzarc
force-pushed
the
earlier-slave-matrix-retrieval
branch
from
0860c29
to
ace26c9
Compare
|
@mtei any other concerns, or are we happy with a merge? |
|
It looks like it's working properly. There seems to be no problem. However, I'm not sure the significance of moving 'transport_master()' into 'matrix_pre_scan()'. Current matrix.c timing (click)
This PR's matrix.c timing. (click)
|
@mtei Been a while since I looked at this PR, but I believe it was so that the full matrix is made available at the time EDIT: Re-investigating, I don't think this is an issue with the old behaviour -- will sort out rollback of that specific portion. |
…ntation of display timeouts and the like.
tzarc
force-pushed
the
earlier-slave-matrix-retrieval
branch
from
7427806
to
4efdee0
Compare
|
Newer, simpler implementation seems to work fine. |
mtei
approved these changes
Jan 12, 2021
tzarc
added a commit
to tzarc/qmk_firmware
that referenced
this pull request
Jan 14, 2021
This reverts commit 79d1db3.
14 tasks
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* Allow recording of the last matrix activity time, to simplify implementation of display timeouts and the like. * Add requested changes from code review. * Simplify split matrix last changed.
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
This reverts commit 3d6315d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for recording the last time matrix activity was detected.
Two new APIs have been added:
These values are compatible with normal matrix scanning, as well as split_common.
Types of Changes
Checklist