-
-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Language Specific Keycodes for US International and Extended Layouts #11307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spidey3
changed the title
Improved keymaps for US International and Extended Layouts
Improved Language Specific Keycodes for US International and Extended Layouts
Dec 26, 2020
fauxpark
requested changes
Dec 26, 2020
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
@fauxpark, et. al.:
|
fauxpark
requested changes
Dec 27, 2020
Co-authored-by: Ryan <fauxpark@gmail.com>
fauxpark
requested changes
Dec 27, 2020
Thanks for these suggestions! Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
fauxpark
approved these changes
Dec 27, 2020
drashna
approved these changes
Jan 2, 2021
Thanks! |
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
… Layouts (qmk#11307) Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request improves a corner of the Language Specific Keycodes:
xkb:us:intl:eng
- English (US, international with dead keys)]US_DGRV
vs.US_GRV
,US_DTIL
vs.US_TILD
, etc.)sendstring_us_international.h
that will (if included) makesend_char()
/send_string()
work correctly when the host is configured for this keyboardxkb:us:altgr-intl:eng
- English (international AltGr dead keys)]send_char()
/send_string()
for ASCII characters that can only be entered by typing a dead key followed by a space.I've targeted this at the
develop
branch, because:send_char()
increases firmware size slightly (by about 62 bytes) for all keyboards.keymap_us_international.h
make it more correct, but may break keymaps that depend on it (although I note, there doesn't seem to be anything in theqmk/qmk_firmware
tree that uses it at present).Types of Changes
Checklist