Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a system to map between info.json and config.h/rules.mk #11548

Merged
merged 12 commits into from
Jan 31, 2021
Merged

Create a system to map between info.json and config.h/rules.mk #11548

merged 12 commits into from
Jan 31, 2021

Conversation

skullydazed
Copy link
Member

Description

C developers shouldn't need to dive into Python just to add new config options. This sets up a mapping in data/mappings/info_*.json that's a lot easier to edit and maintain.

Types of Changes

  • Core
  • Enhancement/optimization
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@skullydazed skullydazed requested a review from a team January 14, 2021 17:52
@Erovia Erovia requested a review from a team January 31, 2021 20:42
@skullydazed skullydazed merged commit ef6329a into develop Jan 31, 2021
@skullydazed skullydazed deleted the improved_info_config_bridge branch January 31, 2021 20:46
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@skullydazed
Create a system to map between info.json and config.h/rules.mk (qmk#1…
364281c 
…1548)

* generate rules.mk from a json mapping

* generate rules.mk from a json mapping

* support for config.h from json maps

* improve the mapping system

* document the mapping system

* move data/maps to data/mappings

* fix flake8 errors

* fixup LED_MATRIX_DRIVER

* remove product and description from the vision_division keymap level

* reduce the complexity of generate-rules-mk

* add tests for the generate commands

* fix qmk doctor when submodules are not clean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erovia Erovia Erovia approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
cli qmk cli command documentation keyboard keymap python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skullydazed @tzarc @Erovia