Adds AT90USB162 support #11570
Merged
Adds AT90USB162 support #11570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cli
|
Also I forgot to ask, in common_features there's a comment saying ATmegaxxU2 doesn't have a hardware MUL instruction. When checking the avr instruction set they're listed as AVRe+ cores that should have the instruction with the only missing instructions being "ELPM, EIJMP, EICALL". It wouldn't be the first time the datasheets were wrong about something. I've added the AT90USB162 as a precaution considering the ATmega16u2 should be a replacement and I guess the only downside being performance. |
fauxpark
requested changes
Jan 16, 2021
daskygit
commented
Jan 16, 2021
fauxpark
approved these changes
Jan 17, 2021
drashna
approved these changes
Jan 20, 2021
Co-authored-by: Ryan <fauxpark@gmail.com>
|
Resolved merge conflicts with uart.c and keyboard.jsonschema. |
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* at90usb162 support * fix missing bracket * Apply suggestions from code review Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the AT90USB162.
After my previous PR failure I hope this one is smoother. I've ran
make all:defaultand there are failures with some boards but they appear to happen on develop as well. I've compiled and flashed AT90USB162, ATmega32u4 and STM32F401 boards using this branch.I've added preliminary support into spi_master, uart and serial but I've not tested these features but the registers, bits and pins line up with the datasheet. I've been able to test the changes to backlight_avr on a couple of accessible pins with hardware pwm. I'm a little unsure about the edit I've made to the max eeprom address in dynamic_keymap.c as it doesn't make an exception for the 16u2?
The MCU has no ADCs or support for I2C. I found a datasheet while creating a the first pull request stating the ATmega16u2 is functional equivalent to the AT90USB162 which lines up with the edits I've made.
I'm expecting to have missed something but hopefully not too much.
Edit:
For context this is to port existing hardware to QMK, I appreciate there's not likely going to be much call for this MCU. Any who thanks for your help and time.
Types of Changes
Issues Fixed or Closed by This PR
Checklist