Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing RGB_MODE_TWINKLE / RGB_M_TW keycodes #11935

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Add missing RGB_MODE_TWINKLE / RGB_M_TW keycodes #11935

merged 2 commits into from
Apr 15, 2021

Conversation

spidey3
Copy link
Contributor

@spidey3 spidey3 commented Feb 16, 2021

Description

When the Twinkle effect was implemented, keycodes were not created to select it.
This adds them.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@spidey3 spidey3 requested a review from a team February 16, 2021 18:51
@fauxpark
Copy link
Member

Just a note, this will break VIA. At least the Space Cadet keycodes, and maybe EEPROM reset, though I can't find it in the list.

@spidey3
Copy link
Contributor Author

spidey3 commented Feb 16, 2021 •
edited
Loading

Just a note, this will break VIA. At least the Space Cadet keycodes, and maybe EEPROM reset, though I can't find it in the list.

Ooh, ouch.
Should I re-point it at develop?
Or add it at the end (separate from the rest of the RGB keycodes)?

@spidey3 spidey3 changed the base branch from master to develop February 16, 2021 22:05
@tzarc tzarc closed this Feb 27, 2021
@tzarc tzarc deleted the branch qmk:develop February 27, 2021 20:28
@tzarc
Copy link
Member

tzarc commented Feb 27, 2021

Sorry about that, GitHub decided to delete the develop branch from upstream when we merged it, despite being told otherwise. Reopened.

@tzarc tzarc reopened this Feb 27, 2021
@spidey3 spidey3 removed the on hold label Apr 5, 2021
@spidey3 spidey3 requested a review from drashna April 5, 2021 19:02
@spidey3
Copy link
Contributor Author

spidey3 commented Apr 5, 2021

Rebased, taken off hold.

fauxpark
fauxpark requested changes Apr 6, 2021
View reviewed changes
quantum/quantum_keycodes.h Outdated Show resolved Hide resolved
@spidey3 @fauxpark
Better comment
9f8843f 
Co-authored-by: Ryan <fauxpark@gmail.com>
@spidey3 spidey3 requested a review from fauxpark April 7, 2021 19:41
@spidey3 spidey3 merged commit e2289ff into qmk:develop Apr 15, 2021
@drashna drashna mentioned this pull request May 22, 2021
Closed
14 tasks
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@spidey3 @fauxpark @nhongooi
Add missing RGB_MODE_TWINKLE / RGB_M_TW keycodes (qmk#11935)
d5c5650 
* Add missing RGB_MODE_TWINKLE / RGB_M_TW keycodes

* Better comment

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@spidey3 @fauxpark
Add missing RGB_MODE_TWINKLE / RGB_M_TW keycodes (qmk#11935)
2c4562b 
* Add missing RGB_MODE_TWINKLE / RGB_M_TW keycodes

* Better comment

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spidey3 @fauxpark @tzarc @drashna