Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move print/debug files to quantum #12069

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Move print/debug files to quantum #12069

merged 2 commits into from
Aug 3, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Feb 28, 2021 •
edited
Loading

Description

More small steps to merging tmk_core into quantum....Overall end goals are:

  • Quantum should encapsulate logging facilities
  • Decouple logging from console hid_listen interface
    • For example, it should be possible to throw output to oleds, over rs232, etc

This PR:

  • quantum now owns the print/debug abstraction

Future PRs:

  • swap AVR to lib/printf
    • Trade-off is consistency against the slightly smaller "optimised" AVR implementation
  • Still more work to do, adding in something like a PRINT_BACKEND flag

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Feb 28, 2021
@zvecr zvecr changed the title move print/debug files to quantum Move print/debug files to quantum Feb 28, 2021
@zvecr zvecr added the breaking_change Changes that need to wait for a version increment label Jul 28, 2021
@zvecr zvecr force-pushed the feature/unify_logging3 branch 2 times, most recently from 3c12e7c to cf8cfcb Compare August 2, 2021 21:48
@zvecr zvecr marked this pull request as ready for review August 2, 2021 22:15
@zvecr zvecr removed the in progress label Aug 2, 2021
@zvecr zvecr requested a review from a team August 2, 2021 22:19
@zvecr zvecr merged commit 34de7ca into qmk:develop Aug 3, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@zvecr @nhongooi
Move print/debug files to quantum (qmk#12069)
8d0e5a8 
* move print/debug files to quantum

* Update comments
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
Move print/debug files to quantum (qmk#12069)
33699b2 
* move print/debug files to quantum

* Update comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
breaking_change Changes that need to wait for a version increment core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @fauxpark