Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change BOOTMAGIC_ENABLE=yes to use Bootmagic Lite #12172

Merged
merged 4 commits into from
Apr 12, 2021

Conversation

noroadsleft
Copy link
Member

Description

Changes BOOTMAGIC_ENABLE = yes to use Bootmagic Lite instead of full Bootmagic.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Mar 8, 2021
@noroadsleft noroadsleft force-pushed the develop-bootmagic_yes_to_lite branch from 3798aaf to e2f935f Compare March 8, 2021 23:33
@drashna drashna requested a review from a team March 9, 2021 05:13
@noroadsleft noroadsleft force-pushed the develop-bootmagic_yes_to_lite branch from e2f935f to b8008a0 Compare March 9, 2021 21:57
@noroadsleft
Copy link
Member Author

Last force-push was done to improve the commit message.

@noroadsleft
Copy link
Member Author

And another commit message improvement.

@Erovia Erovia requested a review from a team April 3, 2021 15:51
... instead of full Bootmagic.

This commit changes the meaning of `BOOTMAGIC_ENABLE = yes` to mean "Enable Bootmagic Lite" instead of "Enable full Bootmagic" as previously meant.
This commit updates instances of `BOOTMAGIC_ENABLE = yes` to `BOOTMAGIC_ENABLE = full` to maintain the behavior that was specified by the rule.

Command:

`find keyboards/ layouts/ users/ -type f -name 'rules.mk' -exec sed -i -e 's;\(BOOTMAGIC_ENABLE[ \t]*=[ \t]*\)yes;\1full;g' {} +`
@noroadsleft noroadsleft force-pushed the develop-bootmagic_yes_to_lite branch from af8d95a to 7b38426 Compare April 5, 2021 19:47
@noroadsleft
Copy link
Member Author

noroadsleft commented Apr 5, 2021

Force-pushed to rebase and check for new instances of affected keyboards/keymaps; there were none.

This is good to go. Check that; I never posted the docs. 🤦‍♂️

@noroadsleft noroadsleft marked this pull request as ready for review April 5, 2021 19:48
@Erovia Erovia merged commit a8d64c8 into qmk:develop Apr 12, 2021
@noroadsleft noroadsleft deleted the develop-bootmagic_yes_to_lite branch April 14, 2021 07:41
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jul 30, 2021
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jul 30, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants