-
-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change BOOTMAGIC_ENABLE=yes
to use Bootmagic Lite
#12172
Merged
Erovia
merged 4 commits into
qmk:develop
from
noroadsleft:develop-bootmagic_yes_to_lite
Apr 12, 2021
Merged
Change BOOTMAGIC_ENABLE=yes
to use Bootmagic Lite
#12172
Erovia
merged 4 commits into
qmk:develop
from
noroadsleft:develop-bootmagic_yes_to_lite
Apr 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noroadsleft
force-pushed
the
develop-bootmagic_yes_to_lite
branch
from
March 8, 2021 23:33
3798aaf
to
e2f935f
Compare
drashna
approved these changes
Mar 9, 2021
skullydazed
approved these changes
Mar 9, 2021
noroadsleft
force-pushed
the
develop-bootmagic_yes_to_lite
branch
from
March 9, 2021 21:57
e2f935f
to
b8008a0
Compare
Last force-push was done to improve the commit message. |
noroadsleft
force-pushed
the
develop-bootmagic_yes_to_lite
branch
from
March 9, 2021 22:02
63d936f
to
af8d95a
Compare
And another commit message improvement. |
Erovia
approved these changes
Apr 3, 2021
fauxpark
approved these changes
Apr 4, 2021
... instead of full Bootmagic. This commit changes the meaning of `BOOTMAGIC_ENABLE = yes` to mean "Enable Bootmagic Lite" instead of "Enable full Bootmagic" as previously meant.
This commit updates instances of `BOOTMAGIC_ENABLE = yes` to `BOOTMAGIC_ENABLE = full` to maintain the behavior that was specified by the rule. Command: `find keyboards/ layouts/ users/ -type f -name 'rules.mk' -exec sed -i -e 's;\(BOOTMAGIC_ENABLE[ \t]*=[ \t]*\)yes;\1full;g' {} +`
noroadsleft
force-pushed
the
develop-bootmagic_yes_to_lite
branch
from
April 5, 2021 19:47
af8d95a
to
7b38426
Compare
Force-pushed to rebase and check for new instances of affected keyboards/keymaps; there were none.
|
14 tasks
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Jul 30, 2021
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Jul 30, 2021
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
BOOTMAGIC_ENABLE = yes
to use Bootmagic Lite instead of full Bootmagic.Types of Changes
Checklist