Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RGB/LED Suspend defines #13146

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Fix RGB/LED Suspend defines #13146

merged 1 commit into from
Jun 10, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Jun 9, 2021

Description

Remove the "true"/"false" part from all of the config.h files.

Types of Changes

  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

mtei
mtei approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@mtei mtei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Weak approve.

@mtei mtei requested a review from a team June 9, 2021 06:21
@drashna drashna merged commit 7a6e630 into qmk:develop Jun 10, 2021
@drashna drashna deleted the fix/rgb_matrix_sleep_defines branch June 10, 2021 05:59
This was referenced Jun 10, 2021
Merged
Merged
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jul 30, 2021
@drashna @mechlovin
Fix RGB/LED Suspend defines (qmk#13146)
e8991d1
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jul 30, 2021
@drashna @mechlovin
Fix RGB/LED Suspend defines (qmk#13146)
ed70d46
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@drashna @nhongooi
Fix RGB/LED Suspend defines (qmk#13146)
fcccf86
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@drashna
Fix RGB/LED Suspend defines (qmk#13146)
1b7fc30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@mtei mtei mtei approved these changes

Assignees
No one assigned
Labels
core keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drashna @mtei @fauxpark