Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Add subcommand to generate version.h #13151

Merged
merged 12 commits into from
Jun 26, 2021
Merged

CLI: Add subcommand to generate version.h #13151

merged 12 commits into from
Jun 26, 2021

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jun 9, 2021 •
edited
Loading

Description

More makefile magic converted to Python!

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested review from tzarc, skullydazed and a team June 9, 2021 12:37
@github-actions github-actions bot added the core label Jun 9, 2021
@fauxpark
Copy link
Member Author

fauxpark commented Jun 9, 2021

Now I see there is some similar code already in commands.py for compiling configurator JSONs. I suppose this should all be refactored somehow...

@drashna
Copy link
Member

drashna commented Jun 17, 2021

Merge conflict here.

@fauxpark fauxpark requested a review from Erovia June 18, 2021 18:47
Erovia
Erovia approved these changes Jun 19, 2021
View reviewed changes
Copy link
Member

@Erovia Erovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Only a few remarks, but otherwise good to go.

lib/python/qmk/commands.py Outdated Show resolved Hide resolved
lib/python/qmk/commands.py Outdated Show resolved Hide resolved
lib/python/qmk/commands.py Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from Erovia June 19, 2021 21:26
drashna
drashna approved these changes Jun 26, 2021
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__attribute__((weak)) ✅

@fauxpark fauxpark merged commit bbe43a9 into qmk:develop Jun 26, 2021
@fauxpark fauxpark deleted the cli-generate-version-h branch June 26, 2021 16:29
@gr4yscale gr4yscale mentioned this pull request Jul 6, 2021
Closed
6 tasks
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@fauxpark @nhongooi
CLI: Add subcommand to generate version.h (qmk#13151)
8afdaf0
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@fauxpark
CLI: Add subcommand to generate version.h (qmk#13151)
a8ab24c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skullydazed skullydazed skullydazed approved these changes

@Erovia Erovia Erovia approved these changes

@drashna drashna drashna approved these changes

@tzarc tzarc Awaiting requested review from tzarc

Assignees
No one assigned
Labels
cli qmk cli command core enhancement python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fauxpark @drashna @Erovia @skullydazed