Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matrix consistency check #13470

Merged
merged 2 commits into from
Jul 11, 2021
Merged

Matrix consistency check #13470

merged 2 commits into from
Jul 11, 2021

Conversation

skullydazed
Copy link
Member

Description

This ensures that the reported matrix matches the actual matrix.

Types of Changes

  • Core
  • Enhancement/optimization

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@skullydazed skullydazed requested a review from a team July 6, 2021 17:33
@github-actions github-actions bot added cli qmk cli command python labels Jul 6, 2021
@skullydazed skullydazed mentioned this pull request Jul 6, 2021
Merged
8 tasks
@skullydazed skullydazed marked this pull request as ready for review July 11, 2021 15:43
@skullydazed skullydazed merged commit 0b06452 into develop Jul 11, 2021
@fauxpark fauxpark deleted the matrix_consistency branch August 3, 2021 10:15
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@skullydazed @nhongooi
Matrix consistency check (qmk#13470)
b38547d 
* Add a check to make sure the matrix sizes match the actual matrix size

* make flake8 happy
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@skullydazed
Matrix consistency check (qmk#13470)
63511e9 
* Add a check to make sure the matrix sizes match the actual matrix size

* make flake8 happy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skullydazed @fauxpark