Remove references to info.json width and height in CLI
#13728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skullydazed
approved these changes
Jul 27, 2021
drashna
approved these changes
Jul 27, 2021
14 tasks
purdeaandrei
added a commit
to purdeaandrei/qmk_api
that referenced
this pull request
Sep 18, 2021
See this PR for reference as to why: qmk/qmk_firmware#13728 Included in QMK Breaking Changes - 2021 August 28 Changelog
skullydazed
pushed a commit
to qmk/qmk_api
that referenced
this pull request
Sep 19, 2021
See this PR for reference as to why: qmk/qmk_firmware#13728 Included in QMK Breaking Changes - 2021 August 28 Changelog
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some boards don't have a fixed width and/or height - for example the Wasdat, which can be used in the WASD V2 TKL and fullsize. So having a singular size for a given board does not make much sense as the dimensions depend on, and can (should) be calculated from, the specific layout chosen.
I also scoured the Configurator and it does not appear to use these values anywhere.
Types of Changes
Issues Fixed or Closed by This PR
Checklist