Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI] Add qmk-hid bootloader detection support to qmk console #14038

Merged
merged 6 commits into from
Aug 17, 2021
Merged

[CLI] Add qmk-hid bootloader detection support to qmk console #14038

merged 6 commits into from
Aug 17, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Aug 17, 2021

Description

Like the title says.

Types of Changes

  • Core
  • Enhancement/optimization

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team August 17, 2021 04:47
@github-actions github-actions bot added cli qmk cli command python labels Aug 17, 2021
fauxpark
fauxpark requested changes Aug 17, 2021
View reviewed changes
lib/python/qmk/cli/console.py Outdated Show resolved Hide resolved
@drashna @fauxpark
Remove duplicate entry
b02b73d 
Co-authored-by: Ryan <fauxpark@gmail.com>
@drashna drashna requested a review from a team August 17, 2021 07:06
@github-actions github-actions bot added the core label Aug 17, 2021
sigprof
sigprof requested changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@sigprof sigprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The USB ID for Halfkay in the udev rules is wrong — that bootloader actually uses 16C0:0478 (and the ID is correct in other places).

util/udev/50-qmk.rules Outdated Show resolved Hide resolved
@drashna @sigprof
Update util/udev/50-qmk.rules
64d1b97 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
sigprof
sigprof reviewed Aug 17, 2021
View reviewed changes
util/udev/50-qmk.rules Outdated Show resolved Hide resolved
@drashna @sigprof
Fix VID/PID combos
4fb2e5d 
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
This was referenced Aug 17, 2021
Merged
Merged
sigprof
sigprof approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@sigprof sigprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the udev rules on Linux (NixOS x86_64) using qmk flash with Teensy++ 2.0 (halfkay), nanoBoot (using the same 03eb:2067 ID as QMK/LUFA HID), and also stm32-dfu on STM32F411 and atmel-dfu on atmega32u4; everything works as it should.

@tzarc tzarc merged commit 85351dc into qmk:develop Aug 17, 2021
@drashna drashna deleted the cli/add_qmk_hid branch August 17, 2021 18:22
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@drashna @fauxpark
@sigprof @nhongooi
[CLI] Add qmk-hid bootloader detection support to qmk console (qmk#…
ad89ea6 
…14038)

* [CLI] Add qmk-hid bootloader detection support to `qmk console`

* Remove duplicate entry

Co-authored-by: Ryan <fauxpark@gmail.com>

* Begrudgingly add lufa-ms

* Add udev rules for hid bootloaders

* Update util/udev/50-qmk.rules

Co-authored-by: Sergey Vlasov <sigprof@gmail.com>

* Fix VID/PID combos

Co-authored-by: Sergey Vlasov <sigprof@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@drashna @fauxpark @sigprof
[CLI] Add qmk-hid bootloader detection support to qmk console (qmk#…
acbc1ab 
…14038)

* [CLI] Add qmk-hid bootloader detection support to `qmk console`

* Remove duplicate entry

Co-authored-by: Ryan <fauxpark@gmail.com>

* Begrudgingly add lufa-ms

* Add udev rules for hid bootloaders

* Update util/udev/50-qmk.rules

Co-authored-by: Sergey Vlasov <sigprof@gmail.com>

* Fix VID/PID combos

Co-authored-by: Sergey Vlasov <sigprof@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skullydazed skullydazed skullydazed left review comments

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

@sigprof sigprof sigprof approved these changes

Assignees
No one assigned
Labels
cli qmk cli command core python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@drashna @sigprof @tzarc @fauxpark @skullydazed