Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy Makefile functionality #14858

Merged
merged 1 commit into from
Oct 17, 2021
Merged

Remove legacy Makefile functionality #14858

merged 1 commit into from
Oct 17, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 17, 2021 •
edited
Loading

Description

Given the direction of the cli (and its execution of build_keyboard.mk directly), its unlikely the make KEYBOARD=... logic is going to be required.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team October 17, 2021 22:18
@github-actions github-actions bot added the core label Oct 17, 2021
@zvecr zvecr merged commit ad2b017 into qmk:develop Oct 17, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Oct 19, 2021
Merge remote-tracking branch 'qmk/develop' into develop
c1d4d46 
* qmk/develop: (26 commits)
  [DOCS] Fix the STENO_COMBINEDMAP table (qmk#14883)
  Fix builds for ChibiOS + Cortex-M0[+] (qmk#14879)
  Split out HAPTIC_ENABLE to have separate DRIVER option (qmk#14854)
  [Core] Add support for RISC-V builds and GD32VF103 MCU (qmk#12508)
  Add HT32 support to core (qmk#14388)
  preonic/rev3_drop: Fix old custom matrix code (qmk#14857)
  Remove legacy Makefile functionality (qmk#14858)
  Infer more when building features (qmk#13890)
  [Keymap] added media controls, copy and paste; moved print screen (qmk#14850)
  [Keyboard] Add SpiderIsland 25 key keyboard (qmk#14793)
  [Keyboard] Update Support for The Uni (qmk#14569)
  Try to clarify "number of elements in info.json does not match" error (qmk#14844)
  [Keyboard] Fix minor typo in Ploopy Trackball Nano Docs (qmk#14717)
  add docs/ja/ja_doc_status.sh (qmk#14402)
  [Keyboard] Amended Some Pins - KiwiKeebs Macro V2 (qmk#14824)
  [Keyboard] Adding CK60 and CK65 (qmk#14737)
  [Keymap] Update Miryoku (qmk#14827)
  [Keymap] Drashna Keymap Updates (qmk#14842)
  [Keyboard] Tractyl Manuform Updates (qmk#14841)
  [Keymap] Added GMMK Pro keymap with RGB  (qmk#14648)
  ...
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@zvecr @ptrxyz
Remove legacy Makefile functionality (qmk#14858)
93b2265
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
Remove legacy Makefile functionality (qmk#14858)
b5ed77b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @fauxpark