Revert to old init order for host driver #15029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Nov 2, 2021
tzarc
added a commit
to tzarc/qmk_firmware
that referenced
this pull request
Nov 2, 2021
ptrxyz
pushed a commit
to ptrxyz/qmk_firmware
that referenced
this pull request
Apr 9, 2022
* Partially revert 14888
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially reverts #14888 due to some form of condition between when keyboard_init is called and when the host driver is set. This was reproduced by spamming a key on startup, where it would then not recover and never output any keys.
This close to the code freeze, its not worth breaking a bunch of edge cases.
Types of Changes
Checklist