Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Revert backlight pins on function call #15205

Merged
merged 1 commit into from
Nov 18, 2021
Merged

[Bug] Revert backlight pins on function call #15205

merged 1 commit into from
Nov 18, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Nov 18, 2021

Description

Reverts the change to turn the pins on, as it's erroring out, and backlight_common properly handles it.

Types of Changes

  • Core
  • Bugfix

Issues Fixed or Closed by This PR

  • Tzarc CI

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested review from Duckle29, tzarc and a team November 18, 2021 18:27
@tzarc tzarc merged commit 50dc313 into qmk:develop Nov 18, 2021
@drashna drashna deleted the core/backlight_fix_redux branch November 18, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@Duckle29 Duckle29 Awaiting requested review from Duckle29

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drashna @tzarc