Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Makefile optimisations #16015

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 23, 2022

Description

Some perf. some tidy up.

  • Remove more unused content
  • Avoid as much as possible when running simple commands like make clean
    • Be lazier when handling test discovery
    • No point generating version.h
  • Align location of phony targets

Terrible perf testing...

msys before

$ time make clean
QMK Firmware 0.15.11
Deleting .build/ ... done.

real    0m5.124s
user    0m0.122s
sys     0m0.288s

msys after

$ time make clean
QMK Firmware 0.15.11
Deleting .build/ ... done.

real    0m0.322s
user    0m0.075s
sys     0m0.166s

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jan 23, 2022
@zvecr zvecr requested a review from a team January 24, 2022 15:29
@zvecr zvecr marked this pull request as ready for review January 24, 2022 15:34
@zvecr zvecr merged commit bf9569d into qmk:develop Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants