Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial migration of suspend callbacks #16067

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Initial migration of suspend callbacks #16067

merged 2 commits into from
Feb 4, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 27, 2022 •
edited
Loading

Description

Initial plans were more ambitious, but as least this first iteration removes a tiny bit of the duplication.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jan 27, 2022
@drashna drashna requested a review from a team January 27, 2022 05:12
@zvecr zvecr marked this pull request as ready for review January 27, 2022 12:52
@zvecr zvecr changed the title Initial migration of suspend logic Initial migration of suspend callbacks Jan 27, 2022
@tzarc tzarc merged commit 135c935 into qmk:develop Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @tzarc