Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Size reduction for kbdfans/kbd67/mkiirgb_iso #16601

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Size reduction for kbdfans/kbd67/mkiirgb_iso #16601

merged 1 commit into from
Mar 10, 2022

Conversation

waffle87
Copy link
Member

@waffle87 waffle87 commented Mar 10, 2022 •
edited
Loading

Description

Numerous reports of firmware compiling too large for this keyboard, which can be reproduced using QMK Configurator (likely attributed to avr-gcc version). Removed some RGB matrix effects, as well as RGB light related things.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

#16565

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team March 10, 2022 01:37
@drashna drashna merged commit 708b3f9 into qmk:master Mar 10, 2022
@waffle87 waffle87 deleted the kbd67mkiirgbiso_size branch March 10, 2022 04:12
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@waffle87 @zykrah
[Keyboard] Size reduction for kbdfans/kbd67/mkiirgb_iso (qmk#16601)
87f8845
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waffle87 @drashna @fauxpark